code review issues are resolved

ardeois · Feb 13, 2025 · 4211203 · 4211203
1 parent b42f196
commit 4211203
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -837,6 +837,9 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
 
     const { includedTypes, excludedTypes } = config;
     const shouldGenerateMockForType = (typeName: string) => {
+        if (!typeName) {
+            return true;
+        }
         if (includedTypes && includedTypes.length > 0) {
             return includedTypes.includes(typeName);
         }

diff --git a/tests/__snapshots__/typescript-mock-data.spec.ts.snap b/tests/__snapshots__/typescript-mock-data.spec.ts.snap
@@ -1594,6 +1594,32 @@ export const aQuery = (overrides?: Partial<Query>): Query => {
 "
 `;
 
+exports[`should generate mock data only for included types 1`] = `
+"
+export const anAvatar = (overrides?: Partial<Avatar>): Avatar => {
+    return {
+        id: overrides && overrides.hasOwnProperty('id') ? overrides.id! : '1550ff93-cd31-49b4-a3c3-8ef1cb68bdc3',
+        url: overrides && overrides.hasOwnProperty('url') ? overrides.url! : 'consectetur',
+    };
+};
+
+export const aUser = (overrides?: Partial<User>): User => {
+    return {
+        id: overrides && overrides.hasOwnProperty('id') ? overrides.id! : 'b5756f00-51a6-422a-81a7-dc13ee6a6375',
+        creationDate: overrides && overrides.hasOwnProperty('creationDate') ? overrides.creationDate! : '2021-06-27T14:29:24.774Z',
+        login: overrides && overrides.hasOwnProperty('login') ? overrides.login! : 'sordeo',
+        avatar: overrides && overrides.hasOwnProperty('avatar') ? overrides.avatar! : anAvatar(),
+        status: overrides && overrides.hasOwnProperty('status') ? overrides.status! : Status.Online,
+        customStatus: overrides && overrides.hasOwnProperty('customStatus') ? overrides.customStatus! : AbcStatus.HasXyzStatus,
+        scalarValue: overrides && overrides.hasOwnProperty('scalarValue') ? overrides.scalarValue! : 'arx',
+        camelCaseThing: overrides && overrides.hasOwnProperty('camelCaseThing') ? overrides.camelCaseThing! : aCamelCaseThing(),
+        unionThing: overrides && overrides.hasOwnProperty('unionThing') ? overrides.unionThing! : anAvatar(),
+        prefixedEnum: overrides && overrides.hasOwnProperty('prefixedEnum') ? overrides.prefixedEnum! : PrefixedEnum.PrefixedValue,
+    };
+};
+"
+`;
+
 exports[`should generate mock data with PascalCase enum values by default 1`] = `
 "
 export const anAvatar = (overrides?: Partial<Avatar>): Avatar => {

diff --git a/tests/typescript-mock-data.spec.ts b/tests/typescript-mock-data.spec.ts
@@ -603,6 +603,7 @@ it('should generate mock data only for included types', async () => {
         includedTypes: ['User', 'Avatar'],
     });
 
+    expect(result).toMatchSnapshot();
     expect(result).toBeDefined();
     expect(result).toContain('export const aUser');
     expect(result).toContain('export const anAvatar');