SSR not working with graphql@16

[liuderchi]

Hi, I have SSR issues when upgrading graphql from v15 to v16 with following SSR tech stack:

• next@latest, apollo-server-express@3.5
• 1️⃣ @graphql-tools/utils -> used for custom GQL directive
• 2️⃣ @graphql-tools/schema -> used makeExecutableSchema for SSR support with SchemaLink
  • e.g.

import { SchemaLink } from '@apollo/client/link/schema'
import { makeExecutableSchema } from '@graphql-tools/schema'
// ...
const schemaLink = new SchemaLink({
  schema: makeExecutableSchema({
    typeDefs,
    resolvers,
  })
})

Observed that GQL query results not resolved at server-side-rendering phase, leading to some issues since I hope to query sensitive data only at server side.

---

And observed one thing interesting when debugging:

• with the only one graphql usage from @graphql-tools/* (makeExecutableSchema from @graphql-tools/schema), this issue still exists only after this PR from graphql@16:
  • Remove support for positional args in graphql/execute/subscribe func graphql/graphql-js#2904, which is one of the breaking changes from v16
  • (this was tested with locally built graphql from git commit tree)

So, I'm wondering does makeExecutableSchema already handles this breaking change in graphql@16?

Really appreciate your attention for this issue 🙇

[ardatan]

I don't think this is related to GraphQL Tools. GraphQL Tools here is only responsible of building your schema. Maybe you should create an issue on Apollo's repo