Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow X11 capture on displays with non-zero sequence number #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtinth
Copy link

@dtinth dtinth commented Oct 30, 2020

In some cases, the X11 server can be run with non-zero sequence number. This number is available as $DISPLAY environment variable. This PR adds support for it. https://datacadamia.com/ssh/x11/display

@arciisine
Copy link
Owner

The PR looks good, my primary concern is around the default format for $DISPLAY of :0 vs :0.0. I believe FFMPEG assumes everything is a single display. Would it make sense to ensure we are targeting the 0 screen for which ever display is chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants