fix: run gtest #172
fix: run gtest #172
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request updates two CMake configuration files by changing the minimum required CMake version from 3.18 to 3.25. Additionally, it modifies the case of several CMake commands and variables from lowercase to uppercase. The visibility specifiers for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/std/tests/CMakeLists.txt (1)
13-13: LGTM with a note about CMake best practicesThe variable renaming is consistent. However, note that while using
GLOB_RECURSEfor test files is acceptable, CMake documentation generally recommends explicitly listing source files instead of globbing for better build predictability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/std/tests/CMakeLists.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build_on_macos
- GitHub Check: build_on_ubuntu
🔇 Additional comments (1)
src/std/tests/CMakeLists.txt (1)
15-15: LGTM! Verify test executionThe variable reference update is consistent with the rename. The test configuration looks correct with proper include directories, dependencies, and library linking.
Let's verify the test setup:
✅ Verification successful
✅ Test configuration verified and correct
The test setup is properly configured with:
- Correct test source discovery using KSTD_TEST_SOURCE
- Proper include paths and dependencies
- Consistent use of the new 'kstd' naming
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test file existence and naming convention consistency # Check for test files echo "Checking for test files..." find src/std/tests -name "*.cc" -type f # Verify no remaining references to 'pstd' echo "Checking for any remaining 'pstd' references..." rg -i "pstd" src/std/tests/Length of output: 351
Script:
#!/bin/bash # Check CMake configuration for test setup echo "Checking CMake configuration..." cat src/std/tests/CMakeLists.txt echo -e "\nChecking parent CMake files for test source variable..." find src/std -name "CMakeLists.txt" -type f -exec grep -l "KSTD_TEST_SOURCE" {} \;Length of output: 1498
|
这里目录的单测： |
Single test for this directory: |
Summary by CodeRabbit