style: optimize coding (#809)

cmd/admin.go

@@ -80,8 +80,6 @@ func runAdmin(cmd *cobra.Command, args []string) error {
 		}
 	}
 
-	addr := fmt.Sprintf(":%d", port)
-
 	bootOptions, err := config.LoadBootOptions(bootstrapPath)
 	if err != nil {
 		return err
@@ -95,17 +93,17 @@ func runAdmin(cmd *cobra.Command, args []string) error {
 	}
 	discovery := boot.NewDiscovery(bootstrapPath)
 	if err = boot.Boot(context.Background(), discovery); err != nil {
-		log.Fatal("start failed: %v", err)
+		log.Fatalf("start failed: %v", err)
 		return err
 	}
 
 	registryConf := discovery.GetServiceRegistry(context.Background())
 	serviceDiscovery, err := registry.InitDiscovery(registryConf.Name, registryConf.Options)
 	if err != nil {
-		log.Fatal("init service discovery failed: %v", err)
+		log.Fatalf("init service discovery failed: %v", err)
 		return err
 	}
 
 	adminServer := admin.New(op, serviceDiscovery)
-	return adminServer.Listen(addr)
+	return adminServer.Listen(fmt.Sprintf(":%d", port))
 }

pkg/admin/exception/exception.go

@@ -19,6 +19,7 @@ package exception
 
 import (
 	"fmt"
+	"net/http"
 )
 
 const (
@@ -30,20 +31,19 @@ const (
 )
 
 var _httpStatus = map[Code]int{
-	CodeNotFound:      404,
-	CodeInvalidParams: 400,
-	CodeAuth:          401,
-	CodeServerError:   500,
+	CodeNotFound:      http.StatusNotFound,
+	CodeInvalidParams: http.StatusBadRequest,
+	CodeAuth:          http.StatusUnauthorized,
+	CodeServerError:   http.StatusInternalServerError,
 }
 
 type Code uint16
 
 func (ec Code) HttpStatus() int {
-	hc, ok := _httpStatus[ec]
-	if ok {
+	if hc, ok := _httpStatus[ec]; ok {
 		return hc
 	}
-	return 500
+	return http.StatusInternalServerError
 }
 
 type APIException struct {

pkg/admin/jwt.go

@@ -144,9 +144,5 @@ func validateUser(tenant, username, password string) bool {
 		return false
 	}
 
-	if username != supervisor.Username || password != supervisor.Password {
-		return false
-	}
-
-	return true
+	return !(username != supervisor.Username || password != supervisor.Password)
 }

pkg/admin/router/users.go

@@ -134,7 +134,7 @@ func CreateUser(c *gin.Context) error {
 		}
 	}
 
-	if err := admin.GetService(c).UpsertUser(c, tenant, &user, user.Username); err != nil {
+	if err = admin.GetService(c).UpsertUser(c, tenant, &user, user.Username); err != nil {
 		return err
 	}