Merge pull request #51 from aragon/fix-empty-strings

Fix evaluator crash with empty strings
aragon · Nov 13, 2018 · 4922768 · 4922768
2 parents 2038f97 + b2618ad
commit 4922768
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 38 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/evaluator/index.js b/src/evaluator/index.js
@@ -98,7 +98,7 @@ class Evaluator {
     }
 
     if (node.type === 'StringLiteral') {
-      return new TypedValue('string', node.value)
+      return new TypedValue('string', node.value || '')
     }
 
     if (node.type === 'NumberLiteral') {

diff --git a/test/examples/examples.js b/test/examples/examples.js
@@ -166,6 +166,10 @@ const cases = [
     source: 'a is `a`, b is `b` and "c d" is `c d`',
     bindings: { a: int(1), b: int(2), c: int(3), d: int(4) }
   }, 'a is 1, b is 2 and "c d" is 3 4'],
+  [{
+    source: 'An empty string`\'\'`',
+    bindings: { }
+  }, 'An empty string'],
 
   // Maths
   [{