Skip to content
This repository was archived by the owner on May 21, 2019. It is now read-only.

Voting app card view #10

Open
jounih opened this issue Sep 11, 2018 · 4 comments
Open

Voting app card view #10

jounih opened this issue Sep 11, 2018 · 4 comments
Assignees
@bpierre @sohkai
Labels
design: implemented

Comments

@jounih
Copy link
Contributor

jounih commented Sep 11, 2018 •
edited
Loading

Since the Survey app card view is responsive and works well on mobile, we should re-use it for the Voting app with some tweaks.

Improvements compared to the previous voting app UI:

  • Responsive, works on mobile
  • Using "You" tag to show which votes you have voted on, and how you voted (once authenticated with a wallet)
  • Introduction of a filter component to filter past votes
  • Clearer UX for changing your vote (as long as the vote hasn't timed out)

Clickthrough prototype - https://invis.io/XGNZRCS46UK

webapp-1366px - vote card view 2x

webapp-1366px - vote card view vote 2x

webapp-1366px - vote card view change vote 2x
@jounih jounih mentioned this issue Sep 11, 2018
Closed
@sohkai sohkai added this to the sprint: 1.2 milestone Sep 11, 2018
@sohkai
Copy link

sohkai commented Sep 11, 2018 •
edited
Loading

@jounih Could you also include the "execute" functionality? I assume it'd just be the button in the panel changing to be "execute"?

Nevermind, I see it's in aragon/aragon-apps#216 (comment) :).

@bpierre bpierre mentioned this issue Sep 15, 2018
Merged
7 tasks
bpierre added a commit to aragon/aragon-apps that referenced this issue Sep 21, 2018
@bpierre
Voting: updates (#448)
d62f2b6 
- Upgrade eslint.
- Move to parcel (from react-scripts).
- Move to react-spring (from react-motion).
- Card layout (issue: aragon/design#10).
- Display the user vote (“Your vote” badge) and the block number on the cards.
- Display the correct balance (PR: #449).
- Execute a vote (issue: #216 (comment), PR: #450).
- Explicitly change a vote (PR: #450).
- Fix the bars transitions.
- Update Aragon UI (fix the flickering when opening the sidebar on Chrome).
@cfl0ws
Copy link

cfl0ws commented Sep 24, 2018

@bpierre Should this be moved to the Done column? If so, please add it, if not, please add a short note here explaining why not.

@bpierre
Copy link
Contributor

bpierre commented Sep 24, 2018

Yes we can close it!

@bpierre bpierre closed this as completed Sep 24, 2018
@sohkai
Copy link

sohkai commented Sep 25, 2018

@chris-remus @bpierre We discussed with @jounih on closing design issues before, and we came to the conclusion that we wouldn't close them (since they're not really "issues") but leave them open on this repo. I usually move them to the "Design implemented" column and remove them from any connected epics or milestones (to avoid dangling issues in them).

@sohkai sohkai reopened this Sep 25, 2018
@sohkai sohkai removed this from the sprint: 1.2 milestone Sep 25, 2018
facuspagnuolo pushed a commit to aragon/svrp that referenced this issue Jan 13, 2019
@bpierre
Voting: updates (#448)
759ba25 
- Upgrade eslint.
- Move to parcel (from react-scripts).
- Move to react-spring (from react-motion).
- Card layout (issue: aragon/design#10).
- Display the user vote (“Your vote” badge) and the block number on the cards.
- Display the correct balance (PR: #449).
- Execute a vote (issue: #216 (comment), PR: #450).
- Explicitly change a vote (PR: #450).
- Fix the bars transitions.
- Update Aragon UI (fix the flickering when opening the sidebar on Chrome).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpierre bpierre

@sohkai sohkai

Labels
design: implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bpierre @sohkai @cfl0ws @jounih