Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View button lead to blank page #1644

Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix: View button lead to blank page #1644

merged 1 commit into from
Nov 16, 2024

Conversation

neeraj10122004
Copy link
Contributor

View button lead to blank page and #1641

Title : View button lead to blank page

Issue No. : #1641

Code Stack : HTML and JS

Close #1641

Description

As Live google map API is not free instead of using it for time being and look of website i suggest using Leaflet.js which provides basic map we can statically add the locations of the places in this Leaflet.js based code

Video/Screenshots (mandatory)

image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 3a2cd55
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/673771acbd88aa00082616ff
😎 Deploy Preview https://deploy-preview-1644--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neeraj10122004 neeraj10122004 changed the title View button lead to blank page fix: View button lead to blank page Nov 15, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neeraj10122004 good work

@apu52 apu52 merged commit 213dcec into apu52:main Nov 16, 2024
6 of 7 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1644 has been merged! 🎉🎉

@apu52
Copy link
Owner

apu52 commented Nov 16, 2024

@neeraj10122004 i have merged the PR this time , but from next time please try to submit PR only after getting assigned to that issue , otherwise it will violate this repo contribution rules

@apu52 apu52 added bug Something isn't working ieee-igdtuw labels Nov 16, 2024
@neeraj10122004
Copy link
Contributor Author

ok thank you @apu52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ieee-igdtuw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: View button lead to blank page
2 participants