Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: faq changes - dark mode title #1639

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

saumyayadav25
Copy link

@saumyayadav25 saumyayadav25 commented Nov 12, 2024

Title and Issue number

Title : FAQ dark-mode heading

Issue No. : #1638

Code Stack :

Close #1638

Description

In dark mode, title was not visible of faq,
also, the accordion icon was not visible clearly in any mode.

Video/Screenshots (mandatory)

Before:

Screenshot 2024-11-12 at 7 30 27 PM

After:
Screenshot 2024-11-12 at 7 30 22 PM

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under IEEE-IGDTUW Open Source Week 2024

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 3938f5d
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6733605bce1a0d0008872c23
😎 Deploy Preview https://deploy-preview-1639--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@apu52 apu52 changed the title faq changes - dark mode title feat: faq changes - dark mode title Nov 13, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saumyayadav25 good work thanks for your valuable contribution

@apu52 apu52 merged commit 1e66441 into apu52:main Nov 13, 2024
6 of 8 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1639 has been merged! 🎉🎉

@apu52 apu52 added bug Something isn't working ieee-igdtuw labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ieee-igdtuw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FAQ dark-mode heading
2 participants