fix: Logo rendering and fix styles #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Zubaida0113
changed the title
|
@apu52 Please review this PR as soon as possible. |
apu52
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
@Zubaida0113 good work , thanks for your valuable contribution
|
🎉🎉 Thank you for your contribution! Your PR #1637 has been merged! 🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title and Issue number
Title : [Bug]: Redirecting links of Services tab is not working, Logo not rendering on website and Light/Dark Mode inconsistency between Book Now page and website.
Issue No. :#1629
Code Stack : Html, CSS, javascript
Close #1629
Description
Logo Rendering on Specific Pages: The logo should appear consistently across all pages, including the About Us, Top Deals, and Rate Us pages. The logo should render correctly regardless of the page to provide a uniform look across the website
Logo Mismatch on Certain Pages: Once clarified, either the orange background logo or the blue earth logo should be used consistently across all pages. The logo design should be identical on the Book Now, Plan a Trip, and Membership pages to avoid confusion and reinforce brand identity.
Services Tab Redirection: Each sub-service under the Services tab (such as Destinations, Trip Gallery, and Hotels and Resorts) should redirect to the correct page when clicked. The links should be updated to avoid "Not Found" errors, ensuring a smooth navigation experience for users.
Light/Dark Mode Synchronization: The Book Now page should synchronize its theme with the rest of the website. If the user is in dark mode on any page and navigates to Book Now, it should also display in dark mode, and vice versa. This synchronization should apply globally across all pages.
Navbar Button Design Consistency: The Login and View buttons should have a consistent design on all pages. The styling seen on the Home page should be applied across the About, Packages, and other sections, ensuring uniformity in button appearance across the website.
Video/Screenshots (mandatory)
Type of PR
Checklist:
contributing.mdfile before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24 ExtendedHacktoberfest'24