fix: Packages page #1397 #1575
Closed
fix: Packages page #1397 #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JitDey2004
changed the title
apu52
requested changes
Oct 28, 2024
There was a problem hiding this comment.
@JitDey2004 this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
apu52
requested changes
Oct 29, 2024
There was a problem hiding this comment.
@JitDey2004 there is some unwanted changes happened due to your changes in the commits
like there is a padding in every page .please try to resolve it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Package tab the logo and some images are not showing in package plz check this out and fix it #1397
Title : Solved Packages Page #1397
Issue No. : #1397
Code Stack :
Close #1397
Description
Firstly, I found a problem in the packages.html file that its CSS part is not working properly, so I fixed this, and after that, the images are not linked to the html file, and for the location of image files, it's hard to provide dimensions in that, so I changed the location and gave proper dimensions to the images. I fix the header part of the page after changing in the html file. and also change something in the styles.css file .
Video/Screenshots (mandatory)
Type of PR - Bug fix
Checklist:
contributing.mdfile before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24 ExtendedHacktoberfest'24Tourguide.-.Google.Chrome.2024-10-27.09-50-29.mp4