-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Position of Night mode button #1541
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @manikdamle! Thank you for your valuable contribution! Our team will review it and get back to you soon.
@apu52 Pls review |
Hey @apu52 , can you pls review and merge if everything is ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manikdamle this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr
@apu52 resolved them. Pls check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recording.2024-10-28.202400.mp4
the changes u have made due to that the hamburger icon in the small width screen of the website does not working due to overlapping with the theme toggle .please try to fix that
Title and Issue number
Title :Night mode button was not clearly visible in the navbar
Issue No. : #1430
Code Stack :
Close #<#1430>
Description
Night mode button was not clearly visible in the navbar. It is now visible.
Video/Screenshots (mandatory)
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24 Extended
Hacktoberfest'24