From 29b3f31dd7efba9d57674ca355bb598c43f8c8de Mon Sep 17 00:00:00 2001 From: tglide <26071571+TGlide@users.noreply.github.com> Date: Wed, 18 Oct 2023 19:08:52 +0100 Subject: [PATCH 1/3] fix image z-index --- src/markdoc/nodes/Image.svelte | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/markdoc/nodes/Image.svelte b/src/markdoc/nodes/Image.svelte index 4d980bd883..6f416c05ff 100644 --- a/src/markdoc/nodes/Image.svelte +++ b/src/markdoc/nodes/Image.svelte @@ -82,6 +82,7 @@ position: fixed; inset: 0; background-color: rgba(0, 0, 0, 0.25); + z-index: 1000; } .content { @@ -95,5 +96,7 @@ max-height: 75vh; max-width: calc(100% - 2.5rem); + + z-index: 1000; } From 503cc97b5e046344778130d29c32558897728303 Mon Sep 17 00:00:00 2001 From: tglide <26071571+TGlide@users.noreply.github.com> Date: Wed, 18 Oct 2023 19:11:32 +0100 Subject: [PATCH 2/3] fix scroll to top --- src/app.html | 74 +-- src/lib/actions/scrollToTop.ts | 16 + src/lib/layouts/DocsArticle.svelte | 233 +++---- src/lib/layouts/DocsTutorial.svelte | 7 +- .../[platform]/[service]/+page.svelte | 7 +- src/routes/kitchensink/+page.svelte | 614 +++++++++--------- 6 files changed, 496 insertions(+), 455 deletions(-) create mode 100644 src/lib/actions/scrollToTop.ts diff --git a/src/app.html b/src/app.html index 54720a768d..8950633bb9 100644 --- a/src/app.html +++ b/src/app.html @@ -1,41 +1,41 @@ + + + + + + + - - - - - - - - - %sveltekit.head% - + %sveltekit.head% + - - -
%sveltekit.body%
- - - \ No newline at end of file + + +
%sveltekit.body%
+ + diff --git a/src/lib/actions/scrollToTop.ts b/src/lib/actions/scrollToTop.ts new file mode 100644 index 0000000000..c2f09f2eb0 --- /dev/null +++ b/src/lib/actions/scrollToTop.ts @@ -0,0 +1,16 @@ +export const scrollToTop = (node: HTMLElement) => { + const handleClick = () => { + window.scrollTo({ + top: 0, + behavior: 'smooth' + }); + }; + + node.addEventListener('click', handleClick); + + return { + destroy() { + node.removeEventListener('click', handleClick); + } + }; +}; diff --git a/src/lib/layouts/DocsArticle.svelte b/src/lib/layouts/DocsArticle.svelte index 5f2f8f0d7e..2578d08acb 100644 --- a/src/lib/layouts/DocsArticle.svelte +++ b/src/lib/layouts/DocsArticle.svelte @@ -1,126 +1,139 @@
-
-
-
- {#if back} - +
+
+ {#if back} + - - {/if} -
    - -
-
- {#if back} - + + {/if} +
    + +
+
+ {#if back} + - - {/if} -

{title}

-
-
-
-
-
- - -
- -
+ aria-label="previous page" + > +
diff --git a/src/lib/layouts/DocsTutorial.svelte b/src/lib/layouts/DocsTutorial.svelte index decfe59645..12075d828a 100644 --- a/src/lib/layouts/DocsTutorial.svelte +++ b/src/lib/layouts/DocsTutorial.svelte @@ -1,4 +1,5 @@ +
-
-
-


+
+
+


-
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
- HEADER - - HEADER - - HEADER - - HEADER -
placeholder textplaceholder textplaceholder textplaceholder text
placeholder textplaceholder textplaceholder textplaceholder text
placeholder textplaceholder textplaceholder textplaceholder text
placeholder textplaceholder textplaceholder textplaceholder text
-
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
+ HEADER + + HEADER + + HEADER + + HEADER +
placeholder textplaceholder textplaceholder textplaceholder text
placeholder textplaceholder textplaceholder textplaceholder text
placeholder textplaceholder textplaceholder textplaceholder text
placeholder textplaceholder textplaceholder textplaceholder text
+
-


-
-
-
-
- inline-code -


-
    -
  • item
    • -
  • item
    • -
  • item
    • -
-


-
    -
  1. item
    2. -
  2. item
    3. -
  3. item
    4. -
-


-
-
- - - - -
-
    -
  • 0
    • -
  • 1
    • -
  • 2
    • -
  • 3
    • -
  • 4
    • -
  • 5
    • -
-
- - - - - Star on GitHub - 99.9k - +


+
+
+
+
+ inline-code +


+
    +
  • item
    • +
  • item
    • +
  • item
    • +
+


+
    +
  1. item
    2. +
  2. item
    3. +
  3. item
    4. +
+


+
+
+ + + + +
+
    +
  • 0
    • +
  • 1
    • +
  • 2
    • +
  • 3
    • +
  • 4
    • +
  • 5
    • +
+
+ + + + + Star on GitHub + 99.9k + - + - + - + - + - -
-
-
-
-
-
- Default -
-
-
-
-
    -
  • -
    - -
    -
    • -
  • - -
    • -
-
-
-
CONTENT
-
-
-
    -
  • - -
    • -
  • - -
    • -
-
+ +
+
+
+
+
+
+ Default +
+
+
+
+
    +
  • +
    + +
    +
    • +
  • + +
    • +
+
+
+
CONTENT
+
+
+
    +
  • + +
    • +
  • + +
    • +
+
-
- link
- disabled link -
+
+ link
+ disabled link +
-
- -
+
+ +
-
- - - - - Star on GitHub - 99.9k - - - -
-
- - - - - Star on GitHub - 99.9k - - - -
-
[TEMP stuff]
-
Eyebrow
-
Caption 400
-
Caption 500
-
Sub Body 400
-
Sub Body 500
-
Main Body 400
-
Main Body 500
-
Description
-
Label
-
Title
-
Display
-
Headline
-
+
+ + + + + Star on GitHub + 99.9k + + + +
+
+ + + + + Star on GitHub + 99.9k + + + +
+
[TEMP stuff]
+
Eyebrow
+
Caption 400
+
Caption 500
+
Sub Body 400
+
Sub Body 500
+
Main Body 400
+
Main Body 500
+
Description
+
Label
+
Title
+
Display
+
Headline
+
From f0a261bdc6cda3a7125678ffafb7a8d46534e22a Mon Sep 17 00:00:00 2001 From: tglide <26071571+TGlide@users.noreply.github.com> Date: Wed, 18 Oct 2023 19:35:31 +0100 Subject: [PATCH 3/3] remove href from scrollers --- src/lib/layouts/DocsArticle.svelte | 5 ++--- src/lib/layouts/DocsTutorial.svelte | 8 ++------ .../[version]/[platform]/[service]/+page.svelte | 5 ++--- src/routes/kitchensink/+page.svelte | 4 ++-- 4 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/lib/layouts/DocsArticle.svelte b/src/lib/layouts/DocsArticle.svelte index 2578d08acb..fa9492b254 100644 --- a/src/lib/layouts/DocsArticle.svelte +++ b/src/lib/layouts/DocsArticle.svelte @@ -108,14 +108,13 @@ {/each}
- +
{/if} diff --git a/src/lib/layouts/DocsTutorial.svelte b/src/lib/layouts/DocsTutorial.svelte index 12075d828a..4caa61a093 100644 --- a/src/lib/layouts/DocsTutorial.svelte +++ b/src/lib/layouts/DocsTutorial.svelte @@ -145,14 +145,10 @@ {/each}
- +
diff --git a/src/routes/docs/references/[version]/[platform]/[service]/+page.svelte b/src/routes/docs/references/[version]/[platform]/[service]/+page.svelte index d567d3a27b..e6afff9de5 100644 --- a/src/routes/docs/references/[version]/[platform]/[service]/+page.svelte +++ b/src/routes/docs/references/[version]/[platform]/[service]/+page.svelte @@ -335,14 +335,13 @@ {/each}
- +
{/if} diff --git a/src/routes/kitchensink/+page.svelte b/src/routes/kitchensink/+page.svelte index 6a73e31abe..ae03c63ce6 100644 --- a/src/routes/kitchensink/+page.svelte +++ b/src/routes/kitchensink/+page.svelte @@ -228,8 +228,8 @@
- link
- disabled link +
+