Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update feature flag refresh interval to 29 minutes #38248

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

rajatagrawal
Copy link
Contributor

@rajatagrawal rajatagrawal commented Dec 19, 2024

Description

This PR increases the frequency of feature flag cache update so that we can test features faster

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12409924411
Commit: 4669afc
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelectorCreateShouldBind_spec.ts
  2. cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_2_spec.ts
  3. cypress/e2e/Regression/ClientSide/ActionExecution/Bug23345_spec.ts
  4. cypress/e2e/Regression/ClientSide/ActionExecution/ClearStore_spec.ts
  5. cypress/e2e/Regression/ClientSide/ActionExecution/Error_handling_spec.ts
  6. cypress/e2e/Regression/ClientSide/ActionExecution/FieldEvaluation_spec.ts
  7. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ActionSelector_General_spec.ts
  8. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_CopyToClipboardFunctions_spec.ts
  9. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_DownloadFunctions_spec.ts
  10. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalRemoveValueFunctions_spec.ts
  11. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalStoreValueFunctions_spec.ts
  12. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts
  13. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_PostWindowFunctions_spec.ts
  14. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ResetWidgetFunctions_spec.ts
  15. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowAlertFunctions_spec.ts
  16. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts
  17. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_StopWatchGeoLocationFunctions_spec.ts
  18. cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_WatchGeoLocationFunctions_spec.ts
  19. cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts
  20. cypress/e2e/Regression/ClientSide/ActionExecution/PostWindowMessage_spec.ts
  21. cypress/e2e/Regression/ClientSide/ActionExecution/RemoveValue_spec.ts
  22. cypress/e2e/Regression/ClientSide/ActionExecution/StoreValue_spec.ts
  23. cypress/e2e/Regression/ClientSide/ActionExecution/disableJSToggle_spec.ts
  24. cypress/e2e/Regression/ClientSide/ActionExecution/uiToCode_spec.ts
  25. cypress/e2e/Regression/ClientSide/Anvil/AnvilAppNavigation_spec.ts
  26. cypress/e2e/Regression/ClientSide/Anvil/AnvilCopyPaste_spec.ts
  27. cypress/e2e/Regression/ClientSide/Anvil/AnvilDnD_spec.ts
  28. cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts
  29. cypress/e2e/Regression/ClientSide/Anvil/AnvilOnCanvasUI_spec.ts
  30. cypress/e2e/Regression/ClientSide/Anvil/AnvilSectionsAndZones_spec.ts
  31. cypress/e2e/Regression/ClientSide/Anvil/AnvilSpaceDistribution_spec.ts
  32. cypress/e2e/Regression/ClientSide/Anvil/AnvilWidgetClicking_spec.ts
  33. cypress/e2e/Regression/ClientSide/AppNavigation/AppNavigationWithAutoLayout_spec.ts
  34. cypress/e2e/Regression/ClientSide/AppNavigation/AppNavigationWithMultiplePages_spec.ts
  35. cypress/e2e/Regression/ClientSide/Autocomplete/Autocomplete_setters_spec.ts
  36. cypress/e2e/Regression/ClientSide/Autocomplete/Bug23641_Spec.ts
  37. cypress/e2e/Regression/ClientSide/Autocomplete/Bugs_AC_Spec.ts
  38. cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC1_spec.ts
  39. cypress/e2e/Regression/ClientSide/Autocomplete/PropertyPaneSuggestion_spec.ts
  40. cypress/e2e/Regression/ClientSide/Binding/ButtonWidgets_NavigateTo_validation_spec.js
  41. cypress/e2e/Regression/ClientSide/Binding/MultiSelect_Button_Text_spec.js
  42. cypress/e2e/Regression/ClientSide/BugTests/AllWidgets_Reset_Spec.ts
  43. cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts
  44. cypress/e2e/Regression/ClientSide/BugTests/Binding_Bug28287_Spec.ts
  45. cypress/e2e/Regression/ClientSide/BugTests/Binding_Bug28731_Spec.ts
  46. cypress/e2e/Regression/ClientSide/BugTests/Bug20275_Spec.js
  47. cypress/e2e/Regression/ClientSide/BugTests/DS_Bug28985_spec.ts
  48. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
  49. cypress/e2e/Regression/ClientSide/BugTests/ImportExport_Bug24486_Spec.ts
  50. cypress/e2e/Regression/ClientSide/BugTests/InputTruncateCheck_Spec.ts
  51. cypress/e2e/Regression/ClientSide/BugTests/JSParse_Spec.ts
  52. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug15909_Spec.ts
  53. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug20841_Spec.ts
  54. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug24194_Spec.ts
  55. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug25894_spec.ts
  56. cypress/e2e/Regression/ClientSide/BugTests/Widget_Bug27119_Spec.ts
  57. cypress/e2e/Regression/ClientSide/BugTests/invalidLintError_Spec.ts
  58. cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
  59. cypress/e2e/Regression/ClientSide/DynamicHeight/DynamicHeightStatbox_spec.ts
  60. cypress/e2e/Regression/ClientSide/DynamicHeight/List_TextWidget_Spec.ts
  61. cypress/e2e/Regression/ClientSide/DynamicHeight/TextWidget_Spec.ts
  62. cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js
  63. cypress/e2e/Regression/ClientSide/ExplorerTests/DragAndDropWidget_spec.js
  64. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js
  65. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
  66. cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
  67. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
  68. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
  69. cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
  70. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
  71. cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js
  72. cypress/e2e/Regression/ClientSide/Github/EnableGithub_spec.ts
  73. cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js
  74. cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_2_spec.js
  75. cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Selected_Widgets_spec.js
  76. cypress/e2e/Regression/ClientSide/IDE/Canvas_View_mode.ts
  77. cypress/e2e/Regression/ClientSide/IDE/IDE_Add_Pane_Interactions_spec.ts
  78. cypress/e2e/Regression/ClientSide/JSLibrary/Custom_lib_spec.ts
  79. cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts
  80. cypress/e2e/Regression/ClientSide/JSObject/JSObjectMutation_spec.ts
  81. cypress/e2e/Regression/ClientSide/Linting/AsyncFunctionsBoundInSyncFields_Spec.ts
  82. cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
  83. cypress/e2e/Regression/ClientSide/Linting/EntityPropertiesLint_spec.ts
  84. cypress/e2e/Regression/ClientSide/Linting/ErrorReporting_spec.ts
  85. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoDimension_2_spec.ts
  86. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoFillWidgets_Basic_2_spec.js
  87. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoFillWidgets_Basic_spec.js
  88. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Container_spec.ts
  89. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Form_spec.ts
  90. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Modal_spec.ts
  91. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Tabs_spec.ts
  92. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoScroll_Validation_spec.js
  93. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionAlgorithm_AutoLayout_Validation_BasicSpec.js
  94. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Corner_Cases_spec.ts
  95. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/FillwidgetResizingSpec.js
  96. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/HugWidgetValidationSpec.js
  97. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ResizingSpec.ts
  98. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/Row_Gap_spec.ts
  99. cypress/e2e/Regression/ClientSide/OneClickBinding/JSEnabledByDefaultExperiment_spec.ts
  100. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/ConnectToWidget_spec.ts
  101. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/FieldConfigModal_spec.ts
  102. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/JSONForm_mongoDB_spec.ts
  103. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/JSONForm_postgres_spec.ts
  104. cypress/e2e/Regression/ClientSide/OneClickBinding/MultiSelectWidget/MultiSelect_MongoDB_spec.ts
  105. cypress/e2e/Regression/ClientSide/OneClickBinding/MultiSelectWidget/MultiSelect_postgres_spec.ts
  106. cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
  107. cypress/e2e/Regression/ClientSide/OneClickBinding/SelectWidget/mongoDB_spec.ts
  108. cypress/e2e/Regression/ClientSide/OneClickBinding/SelectWidget/postgres_spec.ts
  109. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/OneClickBindingMysql_spec.ts
  110. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/Table_MongoDB_spec.ts
  111. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/Table_postgres_spec.ts
  112. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/index_spec.ts
  113. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js
  114. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ErrorMessages_spec.ts
  115. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Logs1_spec.js
  116. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Logs2_spec.js
  117. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_spec.js
  118. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Unique_key_spec.js
  119. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Widget_Error_spec.js
  120. cypress/e2e/Regression/ClientSide/PeekOverlay/PeekOverlay_Spec.ts
  121. cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts
  122. cypress/e2e/Regression/ClientSide/SetProperty/SetOptions_Spec.ts
  123. cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters1_spec.ts
  124. cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts
  125. cypress/e2e/Regression/ClientSide/ThemingTests/ThemeReset_spec.js
  126. cypress/e2e/Regression/ClientSide/ThemingTests/Theme_Basic_spec.js
  127. cypress/e2e/Regression/ClientSide/ThemingTests/Theme_FormWidget_spec.js
  128. cypress/e2e/Regression/ClientSide/ThemingTests/Theme_MultiSelectWidget_spec.js
  129. cypress/e2e/Regression/ClientSide/VisualTests/WidgetsLayout_spec.js
  130. cypress/e2e/Regression/ClientSide/Widgets/Audio/Audio1_spec.ts
  131. cypress/e2e/Regression/ClientSide/Widgets/Audio/AudioRecorder1_spec.ts
  132. cypress/e2e/Regression/ClientSide/Widgets/Audio/AudioRecorder_spec.js
  133. cypress/e2e/Regression/ClientSide/Widgets/Audio/audio_spec.js
  134. cypress/e2e/Regression/ClientSide/Widgets/Button/Button2_spec.ts
  135. cypress/e2e/Regression/ClientSide/Widgets/Button/ButtonGroup2_spec.ts
  136. cypress/e2e/Regression/ClientSide/Widgets/Button/ButtonGroup_spec.js
  137. cypress/e2e/Regression/ClientSide/Widgets/Button/Button_tooltip_spec.js
  138. cypress/e2e/Regression/ClientSide/Widgets/Camera/CameraImage_Spec.ts
  139. cypress/e2e/Regression/ClientSide/Widgets/Camera/CameraVideo_Spec.ts
  140. cypress/e2e/Regression/ClientSide/Widgets/Chart/ChartWidgetErrors_spec.ts
  141. cypress/e2e/Regression/ClientSide/Widgets/Chart/Chart_widget_spec_1.ts
  142. cypress/e2e/Regression/ClientSide/Widgets/Chart/Chart_widget_spec_2.ts
  143. cypress/e2e/Regression/ClientSide/Widgets/Checkbox/CheckBoxGroupTest.ts
  144. cypress/e2e/Regression/ClientSide/Widgets/Checkbox/CheckboxGroup1_spec.js
  145. cypress/e2e/Regression/ClientSide/Widgets/Checkbox/CheckboxGroup2_spec.js
  146. cypress/e2e/Regression/ClientSide/Widgets/Checkbox/CheckboxGroup_withQuery_spec.js
  147. cypress/e2e/Regression/ClientSide/Widgets/CodeScanner/CodeScanner1_spec.ts
  148. cypress/e2e/Regression/ClientSide/Widgets/CodeScanner/CodeScanner2_spec.ts
  149. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInputTest.ts
  150. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInput_ShowStepArrows_spec.js
  151. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInput_spec.js
  152. cypress/e2e/Regression/ClientSide/Widgets/Custom/CustomWidgetDefaultComponent_spec.ts
  153. cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePicker3_spec.ts
  154. cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePickerV2_spec.js
  155. cypress/e2e/Regression/ClientSide/Widgets/Divider/Widget_Divider_spec.ts
  156. cypress/e2e/Regression/ClientSide/Widgets/DocumentViewer/DocumentViewer_spec.ts
  157. cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_spec.js
  158. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_CSV_spec.js
  159. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_spec.js
  160. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/Filepicker1_spec.js
  161. cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_spec.js
  162. cypress/e2e/Regression/ClientSide/Widgets/Image/Image2_Spec.ts
  163. cypress/e2e/Regression/ClientSide/Widgets/Image/Image3_Spec.ts
  164. cypress/e2e/Regression/ClientSide/Widgets/Input/Input2_Spec.ts
  165. cypress/e2e/Regression/ClientSide/Widgets/Input/Input3_Spec.ts
  166. cypress/e2e/Regression/ClientSide/Widgets/Input/InputRTL_support.ts
  167. cypress/e2e/Regression/ClientSide/Widgets/Input/Input_Multiline_spec.js
  168. cypress/e2e/Regression/ClientSide/Widgets/Input/Input_OnFocus_OnBlur_spec.js
  169. cypress/e2e/Regression/ClientSide/Widgets/Input/Inputv2_ShowStepArrows_spec.js
  170. cypress/e2e/Regression/ClientSide/Widgets/Input/Inputv2_spec.js
  171. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_Basic_spec.js
  172. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_CurrencyField_spec.ts
  173. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_FilePicker_spec.js
  174. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Inputs_spec.js
  175. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
  176. cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js
  177. cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_WithOtherWidget_spec.ts
  178. cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_nested_List_widget_spec.js
  179. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_BasicChildWidgetInteraction_spec.js
  180. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_BasicClientSideData_spec.js
  181. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_Copy_Paste_Delete_spec.js
  182. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_EvaluatedPopup_spec.js
  183. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_WithButtonGroupIconWidget_spec.ts
  184. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_onItemClick_spec.js
  185. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_regression_fix_spec.js
  186. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_spec.js
  187. cypress/e2e/Regression/ClientSide/Widgets/ListV2/PropertyPane_spec.ts
  188. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_Widget_With_Button_spec.ts
  189. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_focus_spec.js
  190. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_functionaliy_spec.js
  191. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_spec.ts
  192. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect1_spec.js
  193. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect4_spec.js
  194. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect5_spec.ts
  195. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelectRTL_support.ts
  196. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect_label_value.ts
  197. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiTreeSelect_spec.js
  198. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
  199. cypress/e2e/Regression/ClientSide/Widgets/Others/Divider_spec.js
  200. cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts
  201. cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_spec.js
  202. cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts
  203. cypress/e2e/Regression/ClientSide/Widgets/Others/MapWidget_loading_Spec.ts
  204. cypress/e2e/Regression/ClientSide/Widgets/Others/Progress_spec.js
  205. cypress/e2e/Regression/ClientSide/Widgets/Others/StatBox_DragAndDrop_spec.js
  206. cypress/e2e/Regression/ClientSide/Widgets/PhoneInput/PhoneInput_Part2_spec.ts
  207. cypress/e2e/Regression/ClientSide/Widgets/PhoneInput/Phone_input_spec.js
  208. cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
  209. cypress/e2e/Regression/ClientSide/Widgets/Radio/RadioGroup1_spec.js
  210. cypress/e2e/Regression/ClientSide/Widgets/Radio/RadioGroup2_spec.js
  211. cypress/e2e/Regression/ClientSide/Widgets/Rating/Rating_Widget_spec.ts
  212. cypress/e2e/Regression/ClientSide/Widgets/Select/RTL_support.ts
  213. cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts
  214. cypress/e2e/Regression/ClientSide/Widgets/Select/Select3_Spec.ts
  215. cypress/e2e/Regression/ClientSide/Widgets/Select/Select_Validation_spec.js
  216. cypress/e2e/Regression/ClientSide/Widgets/Select/Select_label_value.ts
  217. cypress/e2e/Regression/ClientSide/Widgets/Select/Select_spec.js
  218. cypress/e2e/Regression/ClientSide/Widgets/Select/Select_widget1_spec.js
  219. cypress/e2e/Regression/ClientSide/Widgets/Select/select_Widget_Bug_spec.js
  220. cypress/e2e/Regression/ClientSide/Widgets/Sliders/CategorySlider_spec.ts
  221. cypress/e2e/Regression/ClientSide/Widgets/Sliders/NumberSlider_spec.ts
  222. cypress/e2e/Regression/ClientSide/Widgets/Sliders/RangeSlider_spec.ts
  223. cypress/e2e/Regression/ClientSide/Widgets/Statbox/Statbox_spec.ts
  224. cypress/e2e/Regression/ClientSide/Widgets/Switch/Switch2_spec.ts
  225. cypress/e2e/Regression/ClientSide/Widgets/Switch/SwitchGroup1_spec.ts
  226. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_tabledata_schema_spec.js
  227. cypress/e2e/Regression/ClientSide/Widgets/TableV2/AddNewRow1_spec.js
  228. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Custom_column_alias_spec.js
  229. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_1_spec.js
  230. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js
  231. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js
  232. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Pagesize_spec.ts
  233. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts
  234. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_2_Spec.ts
  235. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_1_Spec.ts
  236. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts
  237. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_DisplayText_spec.ts
  238. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_PropertyPane_1_spec.js
  239. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Sorting_spec.js
  240. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Widget_Default_Row_spec.js
  241. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_header_menu_visibility_spec.ts
  242. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_tabledata_schema_spec.js
  243. cypress/e2e/Regression/ClientSide/Widgets/TableV2/VirtualRow_spec.js
  244. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/ColumnTypeMenubutton_spec.js
  245. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/ColumnTypesSelect2_spec.ts
  246. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/HTMLCell_spec.ts
  247. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts
  248. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/checkboxCell_spec.js
  249. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/currency_spec.ts
  250. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/switchCell_spec.js
  251. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column1_spec.js
  252. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column2_spec.js
  253. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column3_spec.js
  254. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column_query_change_spec.js
  255. cypress/e2e/Regression/ClientSide/Widgets/TableV2/non_ascii_column_name_spec.js
  256. cypress/e2e/Regression/ClientSide/Widgets/TableV2/server_side_filtering_spec_1.ts
  257. cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts
  258. cypress/e2e/Regression/ClientSide/Widgets/Text/Text2_Spec.ts
  259. cypress/e2e/Regression/ClientSide/Widgets/TreeSelect/Tree_Select_2_spec.ts
  260. cypress/e2e/Regression/ClientSide/Widgets/TreeSelect/Tree_Select_spec.ts
  261. cypress/e2e/Regression/ClientSide/Widgets/Video/Video_spec.ts
  262. cypress/e2e/Regression/ClientSide/Widgets/WidgetCopyPaste_spec.js
  263. cypress/e2e/Regression/ClientSide/Widgets/Widgets_Labels_spec.js
  264. cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
  265. cypress/e2e/Regression/ServerSide/JsFunctionExecution/Fetch_Spec.ts
  266. cypress/e2e/Regression/ServerSide/OnLoadTests/OnLoadActions_Spec.ts
  267. cypress/e2e/Regression/ServerSide/OnLoadTests/PostgresConnections_spec.ts
  268. cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts
  269. cypress/e2e/Regression/ServerSide/QueryPane/QueryPane_Postgres_Spec.js
  270. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
  271. cypress/e2e/Regression/ServerSide/QueryPane/S3_2_spec.ts
  272. cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts
  273. cypress/e2e/Sanity/Datasources/DatasourceForm_spec.js
List of identified flaky tests.
Thu, 19 Dec 2024 11:01:22 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the refresh rate for tenant-level feature flags to improve performance and reduce race conditions during updates.

@rajatagrawal rajatagrawal requested a review from abhvsn December 19, 2024 06:22
Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

Walkthrough

The pull request modifies the FeatureFlagMigrationHelperCEImpl class by changing a constant TENANT_FEATURES_CACHE_TIME_MIN from 115 to 29. This adjustment impacts the caching mechanism for tenant feature flags, potentially altering the refresh rate and timing of feature flag updates within the application's feature flag management system.

Changes

File Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/FeatureFlagMigrationHelperCEImpl.java Updated TENANT_FEATURES_CACHE_TIME_MIN constant from 115 to 29

Possibly related PRs

Suggested labels

Task, Learnability

Suggested reviewers

  • nidhi-nair
  • sharat87

Poem

🚩 Feature flags dancing light,
Thirty-nine minutes, cache so bright!
Constants shift like autumn leaves,
Migration helper softly weaves
A tale of code's nimble flight 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Dec 19, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/FeatureFlagMigrationHelperCEImpl.java (1)

37-37: Consider environment-specific configuration

While the 29-minute refresh interval benefits testing, it could increase load in production. Consider making this value configurable per environment.

-    private static final long TENANT_FEATURES_CACHE_TIME_MIN = 29;
+    @Value("${feature.flag.cache.refresh.interval:29}")
+    private long tenantFeaturesCacheTimeMin;
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65b98c6 and 4669afc.

📒 Files selected for processing (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/FeatureFlagMigrationHelperCEImpl.java (1 hunks)
🔇 Additional comments (1)
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/FeatureFlagMigrationHelperCEImpl.java (1)

37-37: Verify cron execution interval to prevent race conditions

The comment mentions avoiding race conditions by keeping refresh rate lower than cron execution interval. Please verify that the new 29-minute cache time is still safely below the cron schedule defined in ScheduledTaskCEImpl.

✅ Verification successful

Cache time of 29 minutes is safely below scheduled task interval

Based on the findings, the scheduled task runs with a fixed rate of 30 minutes (fixedRate = 30 * 60 * 1000). The new cache time of 29 minutes ensures the cache refresh happens before the next scheduled execution, preventing any race conditions.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for cron schedule configuration in ScheduledTaskCEImpl
rg -A 5 "cron" app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ScheduledTaskCEImpl.java

Length of output: 113


Script:

#!/bin/bash
# Let's try searching for cron or scheduled task related configurations more broadly
rg -i "scheduled|cron|fixedrate|fixeddelay" app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ScheduledTaskCEImpl.java

# Also search for any Spring scheduling annotations
rg "@Scheduled" app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ScheduledTaskCEImpl.java

# Let's also check if there's a different implementation class
fd -e java ScheduledTask

Length of output: 2212


Script:

#!/bin/bash
# Let's check the feature flag migration method to understand how it's scheduled
rg -A 10 "getUpdatedFlagsWithPendingMigration" app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ScheduledTaskCEImpl.java

# Also check if there are any other scheduled tasks that might interact with feature flags
rg -A 5 "@Scheduled.*feature" app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/

Length of output: 249

@rajatagrawal
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12407465720.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38248.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-38248.dp.appsmith.com

@rajatagrawal rajatagrawal added the ok-to-test Required label for CI label Dec 19, 2024
@abhvsn abhvsn removed their request for review December 26, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant