Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

. t add test case for failing exit code #4

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

JayBazuzi
Copy link
Contributor

@JayBazuzi JayBazuzi commented Jan 28, 2025

Summary by Sourcery

Add a test case to verify that a failing exit code is returned when the verification fails.

CI:

  • Verify that failing tests return a non-zero exit code.

Tests:

  • Add a test case for failing exit code.

Copy link

sourcery-ai bot commented Jan 28, 2025

Reviewer's Guide by Sourcery

This pull request adds a test case to verify that the verify.sh script returns a non-zero exit code when a test fails. Additionally, it updates the .gitignore file.

Sequence diagram for verify.sh test failure flow

sequenceDiagram
    participant CI as CI Pipeline
    participant VS as verify.sh
    participant Test

    CI->>VS: Run with -t failing-test
    VS->>Test: Execute test
    Test-->>VS: Test fails
    VS-->>CI: Return non-zero exit code
Loading

Flow diagram for verify.sh exit code behavior

flowchart TD
    A[Start verify.sh] --> B{Run Test}
    B -->|Test Passes| C[Return 0]
    B -->|Test Fails| D[Return Non-zero]
    C --> E[End]
    D --> E
Loading

File-Level Changes

Change Details Files
Added a test case to verify that verify.sh returns a non-zero exit code when a test fails.
  • Added a new job to the CI workflow that runs verify.sh with a failing test and asserts that the exit code is non-zero.
.github/workflows/ci.yml
Updated the .gitignore file.
  • The .gitignore file was modified.
.gitignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nitsanavni nitsanavni merged commit 1064bb1 into approvals:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants