Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- r run mypy #194

Closed
wants to merge 4 commits into from
Closed

- r run mypy #194

wants to merge 4 commits into from

Conversation

JayBazuzi
Copy link
Contributor

@JayBazuzi JayBazuzi commented Nov 12, 2024

Add mypy to run_tests + suppress all existing mypy violations.

Summary by Sourcery

Integrate mypy type checking into the project by adding it to the tox configuration and the CI workflow, while suppressing existing mypy violations.

Enhancements:

  • Integrate mypy type checking into the testing process by adding a new 'type' environment in tox.

CI:

  • Add mypy type checking to the CI workflow by including it in the 'run_tests.sh' script.

Copy link

sourcery-ai bot commented Nov 12, 2024

Reviewer's Guide by Sourcery

This PR adds mypy type checking to the project's test suite and suppresses existing mypy violations. The implementation involves configuring mypy rules in mypy.ini for various modules and integrating mypy into the tox test environment.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Configure mypy type checking rules
  • Add extensive module-specific error code suppressions
  • Exclude .tox/ directory from mypy checks
  • Configure base mypy settings for return type and config warnings
mypy.ini
Integrate mypy into the test infrastructure
  • Add new 'type' environment to tox configuration
  • Configure mypy to check approvaltests and approval_utilities packages
  • Add mypy command to run against specific packages
tox.ini
run_tests.sh
requirements.test.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@JayBazuzi JayBazuzi closed this by deleting the head repository Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant