From f3e7ad4b9a7572156953839350bbfa81ea8d48f6 Mon Sep 17 00:00:00 2001 From: Llewellyn Falco Date: Sun, 2 Feb 2025 20:27:59 +0000 Subject: [PATCH] ! F catchall try/except when downloading Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Jay Bazuzi Co-Authored-By: Nitsan Avni --- approvaltests/internals/logs/log_commons.py | 27 ++++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/approvaltests/internals/logs/log_commons.py b/approvaltests/internals/logs/log_commons.py index 1329795..e65f341 100644 --- a/approvaltests/internals/logs/log_commons.py +++ b/approvaltests/internals/logs/log_commons.py @@ -10,17 +10,20 @@ class LogCommons: @staticmethod def download_script_if_needed(script_basename: str) -> None: - suffix = ".bat" if is_windows_os() else ".sh" - script_name_with_suffix = f"{script_basename}{suffix}" - script_path = Path(APPROVAL_TESTS_TEMP_DIRECTORY) / script_name_with_suffix - if script_path.exists(): - return + try: + suffix = ".bat" if is_windows_os() else ".sh" + script_name_with_suffix = f"{script_basename}{suffix}" + script_path = Path(APPROVAL_TESTS_TEMP_DIRECTORY) / script_name_with_suffix + if script_path.exists(): + return - response = requests.get( - f"https://raw.githubusercontent.com/approvals/ApprovalTests.Java/refs/heads/master/resources/{script_name_with_suffix}" - ) - if response.ok: - script_path.write_text(response.text) + response = requests.get( + f"https://raw.githubusercontent.com/approvals/ApprovalTests.Java/refs/heads/master/resources/{script_name_with_suffix}" + ) + if response.ok: + script_path.write_text(response.text) - make_executable = 0o755 - script_path.chmod(make_executable) + make_executable = 0o755 + script_path.chmod(make_executable) + except: + pass