Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options don't seem to taken into account #31

Open
danjdewhurst opened this issue Jul 18, 2017 · 3 comments
Open

Options don't seem to taken into account #31

danjdewhurst opened this issue Jul 18, 2017 · 3 comments

Comments

@danjdewhurst
Copy link
Contributor

It seems like any options I provide in the published configuration file aren't being passed to the OptimizerFactory. I'm using v2.3 with Laravel 5.2.

@approached
Copy link
Owner

@approached
Copy link
Owner

@danjdewhurst
Copy link
Contributor Author

I was dd()ing the $options variable in \vendor\ps\image-optimizer\src\ImageOptimizer\OptimizerFactory.php, and it wasn't getting set. This was unless I removed the $this->app->singleton() wrapper from the approached/laravel-image-optimizer/blob/master/src/ServiceProvider.php construct, and it seemed to work fine again.

I'm not great with service providers, so I don't really understand what that $this->app->singleton() bit is for!

I apologise if I've brought up a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants