Add SwiftPM diagnose-api-breaking-changes check to 1_x branch. #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
force-pushed
the
breaking_change_1_x
branch
from
6b99679 to
3337788
Compare
Just run this on each PR to flag any changes. This will check against the last tag on this branch so it should collect changes across commits until a new tag is made. If we did accept breaking changes, we'd have to add the exceptions list and/or prevent this step from breaking. We also have to accept changes as a side effect of generating from descriptor.proto as we don't control that and don't really expect folks to need to directly interact with the file, it is just provide to make dealing with .proto file that make use of proto options easier. Used some of the https://github.com/vapor projects for reference and the git magic needed to for the action to run.
thomasvl
force-pushed
the
breaking_change_1_x
branch
from
3337788 to
ef4b721
Compare
thomasvl
requested review from
allevato,
FranzBusch and
tbkka
and removed request for
allevato
tbkka
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just run this on each PR to flag any changes. This will check against the last tag on this branch so it should collect changes across commits until a new tag is made. If we did accept breaking changes, we'd have to add the exceptions list and/or prevent this step from breaking.
We also have to accept changes as a side effect of generating from descriptor.proto as we don't control that and don't really expect folks to need to directly interact with the file, it is just provide to make dealing with .proto file that make use of proto options easier.
Used some of the https://github.com/vapor projects for reference and the git magic needed to for the action to run.