Skip to content

Commit

Permalink
Add regression limits for allocation tests. (#160)
Browse files Browse the repository at this point in the history
Motivation:

We missed these out, which means we failed to detect the massive
allocation win in #159.

Modifications:

Correctly add allocation limits.

Result:

We'll know if we regress.
  • Loading branch information
Lukasa authored Dec 4, 2019
1 parent 7b2e7cf commit b015dcb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docker/docker-compose.1604.51.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ services:
image: swift-nio-ssl:16.04-5.1
environment:
- SANITIZER_ARG=--sanitize=thread
- MAX_ALLOCS_ALLOWED_simple_handshake=740000
- MAX_ALLOCS_ALLOWED_many_writes=201000

performance-test:
image: swift-nio-ssl:16.04-5.1
Expand Down
3 changes: 3 additions & 0 deletions docker/docker-compose.1804.50.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ services:

test:
image: swift-nio-ssl:18.04-5.0
environment:
- MAX_ALLOCS_ALLOWED_simple_handshake=743000
- MAX_ALLOCS_ALLOWED_many_writes=201000

performance-test:
image: swift-nio-ssl:18.04-5.0
Expand Down

0 comments on commit b015dcb

Please sign in to comment.