Fix up Renovate and Dockerfiles #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always do these manually, in line with
This includes Rust and pinning to the "correct" version of the underlying OSes
nmoutschen
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some kinks in how Renovate operated on this repo, including allowing major version bumps and allowing the Rust version to go out of sync between the two images where it's important it remains consistent. This fixes that, adding new Renovate config and updating the Dockerfiles to support it.
Also adds a bit of a security fix such that in our GitHub Actions workflow we pin to specific SHAs for actions rather than mutable tags