[Docs] AS Integrations AWS Lambda 2.0.0 Update #7329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlenderDude
added
the
📝 documentation
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c013fcf:
|
BlenderDude
force-pushed
the
da/lambda-2.0.0-docs-update
branch
from
bb915d4 to
63bd20d
Compare
BlenderDude
force-pushed
the
da/lambda-2.0.0-docs-update
branch
from
63bd20d to
f1fa867
Compare
trevor-scheer
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the v2.0.0 release of
@as-integrations/aws-lambda, the docs needed updates to reflect the new syntax and requirements. This PR also describes more of the added functionality in the 2.0 release.There was also an issue with the local event type that slipped through the cracks the first time around due to our runtime type-parsing. The local event we were using for testing was a
ProxyV1event type, while thehttpApispun up byserverlesswas of theProxyV2type. I normalized the example event and integration example to both be the newV2event type (as its now necessary to be explicit with v2.0.0).Fixes #7327 as
requestContext.http.methodwas missing from the event as it was not required inProxyV1, but is inProxyV2