Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type declarations #37

Merged
merged 6 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"typescript.tsdk": "node_modules/typescript/lib"
}
Comment on lines +1 to +3
Copy link
Contributor Author

@Ha-limLee Ha-limLee Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is vscode ts version setting.

It fixes ts version to workspace's.

Since vscode comes with internal ts, different version of vscode can cause syntactic error.

85 changes: 85 additions & 0 deletions index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
type ValueOf<T> = T[keyof T];

export type Dtypes = {
"<u1": {
name: "uint8";
size: 8;
arrayConstructor: typeof Uint8Array;
};
"|u1": {
name: "uint8";
size: 8;
arrayConstructor: typeof Uint8Array;
};
"<u2": {
name: "uint16";
size: 16;
arrayConstructor: typeof Uint16Array;
};
"|i1": {
name: "int8";
size: 8;
arrayConstructor: typeof Int8Array;
};
"<i2": {
name: "int16";
size: 16;
arrayConstructor: typeof Int16Array;
};
"<u4": {
name: "uint32";
size: 32;
arrayConstructor: typeof Int32Array;
};
"<i4": {
name: "int32";
size: 32;
arrayConstructor: typeof Int32Array;
};
"<u8": {
name: "uint64";
size: 64;
arrayConstructor: typeof BigUint64Array;
};
"<i8": {
name: "int64";
size: 64;
arrayConstructor: typeof BigInt64Array;
};
"<f4": {
name: "float32";
size: 32;
arrayConstructor: typeof Float32Array;
};
"<f8": {
name: "float64";
size: 64;
arrayConstructor: typeof Float64Array;
};
};

export type Parsed = ValueOf<{
Copy link
Contributor Author

@Ha-limLee Ha-limLee Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is return type of parse method.

It is tagged union type. So you can narrow the type using if or switch statements.

image

[K in keyof Dtypes]: {
dtype: Dtypes[K]["name"];
data: InstanceType<Dtypes[K]["arrayConstructor"]>;
shape: number[];
fortranOrder: boolean;
};
}>;

declare class npyjs {

constructor(opts?: never);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made constructor receive nothing.

If user give any argument, It will throw type error.

image


dtypes: Dtypes;

parse(arrayBufferContents: ArrayBuffer): Parsed;

load(
filename: RequestInfo | URL | ArrayBuffer,
callback?: (result?: Parsed) => any,
fetchArgs?: RequestInit
): Promise<Parsed>;
}

export default npyjs;
26 changes: 23 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"node": "^12.20.0 || >=14.13.1"
},
"devDependencies": {
"mocha": "^10.2.0"
"mocha": "^10.2.0",
"typescript": "4.1.x"
},
"scripts": {
"test": "mocha"
Expand Down
15 changes: 15 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
// Change this to match your project
"include": ["index.js"],
"compilerOptions": {
// Tells TypeScript to read JS files, as
// normally they are ignored as source files
"allowJs": true,
// Generate d.ts files
"declaration": true,
// This compiler run should
// only output d.ts files
"emitDeclarationOnly": true,
"target": "ES6"
}
}
Loading