Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds native spelunker support #414

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Adds native spelunker support #414

merged 8 commits into from
Nov 5, 2024

Conversation

dxenes1
Copy link
Collaborator

@dxenes1 dxenes1 commented Oct 23, 2024 •
edited
Loading

  • create example tasks
  • test queue functionality
  • test submission data functionality

@dxenes1 dxenes1 self-assigned this Oct 23, 2024
@hannah-martinez
Copy link
Member

hannah-martinez commented Oct 29, 2024 •
edited
Loading

The queue, workspace, workspace buttons, and dashboard all seem to work correctly from a UI perspective. The Inspect Task tab doesn't seem to work locally. Not sure if that would be fixed through deployment.

@hannah-martinez
Copy link
Member

hannah-martinez commented Oct 29, 2024 •
edited
Loading

I noticed some weird CSS going on. Some of the text boxes are squished.
image

I was able to fix this with some more CSS classes in workspace.css. These were the classes I noticed that needed the change. The list is not exhaustive.

.neuroglancer-display-dimensions-widget-name,
.neuroglancer-position-dimension-scale,
.neuroglancer-position-dimension-coordinate,
.neuroglancer-position-dimension-name{
  box-sizing: content-box;
}

There might be a better spelunker-wide change. I would search for one before applying this bandaid fix.

hannah-martinez
hannah-martinez reviewed Oct 29, 2024
View reviewed changes
neuvue_project/templates/about.html
@@ -82,7 +82,7 @@ <h2 class="pt-5 pb-3"> Collaborators </h2>
<h2 class="pt-5 pb-3"> Contact Us </h2>

<p>
We'd love to hear from you! Reach out at <a class="text-secondary-color-activated" href="mailto:info@neuvue.io">info@neuvue.io</a> with questions or if you are interested in collaborating with us.
We'd love to hear from you! Reach out at <a class="text-secondary-color-activated" href="mailto:info@neuvue.io">info@bossdb.org</a> with questions or if you are interested in collaborating with us.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very glad you are changing this. Can you change the mailto: link as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider it done!

hannah-martinez
hannah-martinez reviewed Oct 29, 2024
View reviewed changes
neuvue_project/workspace/analytics.py
with warnings.catch_warnings():
warnings.simplefilter("ignore")
average_event_time = (m + (namespace_df[status] - m)).mean().to_pydatetime()
changelog.append((average_event_time, n_tasks, status, namespace))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we ignoring warnings here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a previous team member hannah gooden reported annoying warnings here
#382

@dxenes1 dxenes1 mentioned this pull request Nov 5, 2024
Open
@dxenes1 dxenes1 merged commit 425ba07 into main Nov 5, 2024
2 checks passed
@dxenes1 dxenes1 deleted the spelunker branch November 5, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannah-martinez hannah-martinez hannah-martinez approved these changes

Assignees

@dxenes1 dxenes1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxenes1 @hannah-martinez