Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles both MultiDiGraph and DiGraph without up-conversion #55

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Handles both MultiDiGraph and DiGraph without up-conversion #55

merged 1 commit into from
Dec 5, 2024

Conversation

jackboyla
Copy link
Contributor

j6k4m8
j6k4m8 reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@j6k4m8 j6k4m8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing, great work! I want to test this with grand-based graphs to make sure we're hitting the right apis so this doesn't accidentally break any currently working code but I will do that ASAP and merge!

grandcypher/__init__.py Show resolved Hide resolved
@j6k4m8
Copy link
Member

j6k4m8 commented Dec 5, 2024

Perfect! also lolololol @ the branch name @jackboyla!

@j6k4m8 j6k4m8 merged commit ca33ce2 into aplbrain:master Dec 5, 2024
6 checks passed
@j6k4m8 j6k4m8 mentioned this pull request Dec 5, 2024
Open
@jackboyla jackboyla deleted the grandcypher-go-brr branch December 5, 2024 07:01
@j6k4m8 j6k4m8 mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j6k4m8 j6k4m8 j6k4m8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackboyla @j6k4m8