-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add gmaps scraping blog #2772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the article, it is very good and reads well, but it doesn't use the full potential of Crawlee in some places - let's improve that 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is huge, isn't there a more adequate format than gif?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know. any suggestions? gif kinda fits here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebP supports animation as well - I think that's the ideal candidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be webp as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@triposat the file was renamed, but it looks like it's still a png.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janbuchar I didn't get you, sorry :)
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
I've made all the required changes. I've updated the Notion file, including changing all the code snippets, descriptions, and adding more steps. I've also updated the code in the gist files where the complete code is stored. One more thing, regarding the infinite_scrolling() method - it's not working. I tried but couldn't get proper results, so I opted for the general method of scrolling through pages. Apart from this, I have made all the requested changes. Pls review again and let me know if anything else to be changed :) |
I see. Could you please open an issue where you describe what you tried and how exactly it failed so that we can fix it? |
Sure, @janbuchar. Will do it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor comments/suggestions, great job otherwise!
# Tell the crawler how to handle each page it visits | ||
@crawler.router.default_handler | ||
async def default_handler(context): | ||
await scrape_google_maps(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also probably just register scrape_google_maps
as the default handler, like the example that follows this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janbuchar Done. Pls check!
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
website/blog/2024/12-13-scrape-google-maps-using-python/index.md
Outdated
Show resolved
Hide resolved
@janbuchar Made all the changes in the Notion file and also changed the codes in the gist files |
approved by adam and marketing.