fix: Allow config change on PlaywrightCrawler
#1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mylank
changed the title
PlaywrightCrawler
janbuchar
reviewed
May 5, 2025
|
|
||
|
|
||
| async def test_overwrite_configuration() -> None: | ||
| """Check that the configuration is allowed to be passed to the Playwrightcrawler.""" |
There was a problem hiding this comment.
Please mention that the test only checks that the PlaywrightCrawler instantiation does not raise an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is not possible to apply
Configurationto the Playwright crawler (see issue). This is a proposal for a solution.Issues
Testing
Added a test that failed before the fix, but works now.
Checklist