Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] glowDuration or numberOfRepeats #22

Open
aytunch opened this issue Nov 4, 2021 · 6 comments
Open

[Feature request] glowDuration or numberOfRepeats #22

aytunch opened this issue Nov 4, 2021 · 6 comments

Comments

@aytunch
Copy link

aytunch commented Nov 4, 2021

by using duration we set the animation duration of a single ripple effect.
But I want the AvatarGlow to make ripple effect 5 times, each with a 1 second duration
For the current API we can not do this.
Can you please expose numberOfRepeats?

Also null safety version works, so maybe you can update the package's default as the null safe version?
Thanks

@apgapg
Copy link
Owner

apgapg commented Nov 5, 2021

Hi @aytunch I don't get numberOfRepeats thing.
What do you mean by make ripple effect 5 times, each with a 1 second duration ?

@apgapg
Copy link
Owner

apgapg commented Nov 5, 2021

Also package is already null safe and published.

@aytunch
Copy link
Author

aytunch commented Nov 5, 2021

@apgapg right now we can tell the AvatarGlow to
Not animate(animate=false)
Animate once(repeat=false)
Animate forever(repeat=true)

I want to have a repeat count.
This will repeat the glow animation n times and then stop.

Yeah I use the null safe version but the version name is very long

@apgapg
Copy link
Owner

apgapg commented Nov 5, 2021

@aytunch Got that now. You need to define repeat count number. Need to figure out on how to do this. May be a variable counter.

@apgapg
Copy link
Owner

apgapg commented Nov 5, 2021

Would you try contributing this feature? @aytunch

@rohitbhoite
Copy link

Added this change in below PR:
#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants