[TINKERPOP-2489] Server doesn't start if folder has spaces #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #3020 +/- ##
=============================================
+ Coverage 76.14% 76.35% +0.20%
- Complexity 13152 13226 +74
=============================================
Files 1084 1061 -23
Lines 65160 61567 -3593
Branches 7285 7342 +57
=============================================
- Hits 49616 47008 -2608
+ Misses 12839 12036 -803
+ Partials 2705 2523 -182 ☔ View full report in Codecov by Sentry. |
andreachild
reviewed
Feb 6, 2025
andreachild
reviewed
Feb 6, 2025
|
VOTE +1 |
Cole-Greer
reviewed
Feb 7, 2025
Added . to end path with . instead of :
flora-jin
force-pushed
the
TINKERPOP-2489
branch
from
f1d7811 to
77bb65b
Compare
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TINKERPOP: https://issues.apache.org/jira/browse/TINKERPOP-2489
Bug: If working directory contained spaces running gremlin-server.sh resulted in file not found exception
Fix: added quotations to appropriate areas and fixed code that replaced spaces with colons to not change any spaces directory names.