Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEZ-4523: Findbugs build is broken tez-tfile-parser. #319

Merged
merged 1 commit into from
Dec 4, 2023
Merged

TEZ-4523: Findbugs build is broken tez-tfile-parser. #319

merged 1 commit into from
Dec 4, 2023

Conversation

ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Dec 4, 2023

Findbugs build by adding the exclude file.

Fixed 2 findbugs warning highlighted post fix
image

@abstractdog abstractdog self-requested a review December 4, 2023 13:06
abstractdog
abstractdog approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abstractdog
Copy link
Contributor

this blocks precommit in the affected module, merging this now

@abstractdog abstractdog merged commit 0ed5e32 into apache:master Dec 4, 2023
4 checks passed
@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 26m 23s Docker mode activated.
-1 ❌ patch 0m 5s #319 does not apply to master. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/TEZ/How+to+Contribute+to+Tez for help.
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-319/1/artifact/out/Dockerfile
GITHUB PR #319
JIRA Issue TEZ-4523
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-319/1/console
versions git=2.34.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abstractdog abstractdog abstractdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushtkn @abstractdog @tez-yetus