-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-3821: Ability to fail fast tasks that write too much to local disk. #314
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@@ -262,6 +263,13 @@ private synchronized ResponseWrapper heartbeat(Collection<TezEvent> eventsArg) t | |||
sendCounters = true; | |||
prevCounterSendHeartbeatNum = nonOobHeartbeatCounter.get(); | |||
} | |||
try { | |||
task.checkTaskLimits(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this in heartbeat can significantly increase its runtime. As in, even small increase of few milliseconds can have impact on cluster usage. You may want to run this every 10 seconds here or in some other way. This should ideally handle sorter spills and merges, in which case it can handle another ticket which was created on similar lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx Rajesh, there was some logic withHEAP_MEMORY_USAGE_UPDATE_INTERVAL
, I used similar logic here to make sure the check happens at every 10 sec
This comment was marked as outdated.
This comment was marked as outdated.
Minor: change TaskLimitException to some other name, which can represent that limit is related to file bytes written. Rest LGTM. + 1. |
This comment was marked as outdated.
This comment was marked as outdated.
🎊 +1 overall
This message was automatically generated. |
No description provided.