Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4352: Add a web ui interface for TezChild #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abstractdog
Copy link
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdog
Copy link
Contributor Author

can I have a review on this @rbalamohan? the (optional) web ui interface of TezChild is supposed to be the starting point for further improvements like TEZ-4344, TEZ-4345

@guptashailesh92
Copy link

Hi @abstractdog ,
I just have few basic questions. I donot have full context on it so if you can point to some doc that would be great.

  1. Who will be the consumer of the API? How it'll be consumed?
  2. Since ports are dynamic, how will the consumer know service is running on which port? Do you have plan to send this info to Tez AM?

@abstractdog
Copy link
Contributor Author

hey, good questions @guptashailesh92 , here are my thoughts so far:

  1. Consumer can be immediately a human being troubleshooting on a cluster, and also TezAM if we implement TEZ-4344 and TEZ-4345

  2. Yes, exactly, I was about to send this to AM, but the patch suddenly became much more complicated, so I decided to use this as a minimal patch for introducing the web ui only

@guptashailesh92
Copy link

Sure, Thanks a lot.

@abstractdog
Copy link
Contributor Author

@rbalamohan: can you please take a look at this one?

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 18s Maven dependency ordering for branch
+1 💚 mvninstall 10m 19s master passed
+1 💚 compile 1m 2s master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 compile 1m 2s master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚 checkstyle 1m 17s master passed
+1 💚 javadoc 1m 8s master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 javadoc 0m 54s master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+0 🆗 spotbugs 0m 29s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 6s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 38s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 javac 0m 38s the patch passed
+1 💚 compile 0m 37s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚 javac 0m 37s the patch passed
+1 💚 checkstyle 0m 8s tez-api: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
-0 ⚠️ checkstyle 0m 6s tez-runtime-internals: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)
+1 💚 checkstyle 0m 8s The patch passed checkstyle in tez-tests
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 26s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 javadoc 0m 29s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚 findbugs 1m 37s the patch passed
_ Other Tests _
+1 💚 unit 1m 52s tez-api in the patch passed.
+1 💚 unit 0m 39s tez-runtime-internals in the patch passed.
+1 💚 unit 33m 29s tez-tests in the patch passed.
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
74m 43s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/5/artifact/out/Dockerfile
GITHUB PR #248
JIRA Issue TEZ-4352
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux ed896af482cd 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / b95defc
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/5/artifact/out/diff-checkstyle-tez-runtime-internals.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/5/testReport/
Max. process+thread count 1179 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/5/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 24s Maven dependency ordering for branch
+1 💚 mvninstall 10m 16s master passed
+1 💚 compile 0m 59s master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 compile 0m 53s master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚 checkstyle 1m 15s master passed
+1 💚 javadoc 1m 6s master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 javadoc 0m 54s master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+0 🆗 spotbugs 0m 30s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 6s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
+1 💚 mvninstall 0m 39s the patch passed
+1 💚 compile 0m 38s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 javac 0m 38s the patch passed
+1 💚 compile 0m 35s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚 javac 0m 35s the patch passed
+1 💚 checkstyle 0m 8s tez-api: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
-0 ⚠️ checkstyle 0m 6s tez-runtime-internals: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)
+1 💚 checkstyle 0m 7s The patch passed checkstyle in tez-tests
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 27s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚 javadoc 0m 30s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚 findbugs 1m 30s the patch passed
_ Other Tests _
+1 💚 unit 1m 51s tez-api in the patch passed.
+1 💚 unit 0m 36s tez-runtime-internals in the patch passed.
+1 💚 unit 33m 43s tez-tests in the patch passed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
62m 37s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/6/artifact/out/Dockerfile
GITHUB PR #248
JIRA Issue TEZ-4352
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 6e9832d0f9d2 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / b95defc
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/6/artifact/out/diff-checkstyle-tez-runtime-internals.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/6/testReport/
Max. process+thread count 1172 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-248/6/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants