[SPARK-51762][SQL] Fix Resolution of Views in Single-Pass Analyzer When Bridging is Enabled #50555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sql/core/src/test/scala/org/apache/spark/sql/analysis/resolver/MetadataResolverSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/analysis/resolver/MetadataResolverSuite.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/Resolver.scala
Outdated
Show resolved
Hide resolved
.../scala/org/apache/spark/sql/catalyst/analysis/resolver/BridgedRelationMetadataProvider.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
...alyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/BridgedRelationId.scala
Show resolved
Hide resolved
.../scala/org/apache/spark/sql/catalyst/analysis/resolver/BridgedRelationMetadataProvider.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/Resolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/Resolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala
Outdated
Show resolved
Hide resolved
.../scala/org/apache/spark/sql/catalyst/analysis/resolver/BridgedRelationMetadataProvider.scala
Show resolved
Hide resolved
vladimirg-db
approved these changes
Apr 14, 2025
| @@ -101,14 +108,16 @@ class ViewResolver(resolver: Resolver, catalogManager: CatalogManager) | |||
| val prevContext = if (viewResolutionContextStack.isEmpty()) { | |||
| ViewResolutionContext( | |||
| nestedViewDepth = 0, | |||
| maxNestedViewDepth = conf.maxNestedViewDepth | |||
| maxNestedViewDepth = conf.maxNestedViewDepth, | |||
| catalogAndNamespace = unresolvedView.desc.viewCatalogAndNamespace | |||
There was a problem hiding this comment.
This is not needed, right? The copy below is always called.
There was a problem hiding this comment.
Yes, true. But we wanted to make sure that catalogAndNamespace are always provided on construction of the ViewResolutionContext. We can only combine the copy with this if statement. But that seems to make the code less readable.
There was a problem hiding this comment.
This duplication will quickly get annoying, let's not do that.
cloud-fan
approved these changes
Apr 14, 2025
...alyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/BridgedRelationId.scala
Outdated
Show resolved
Hide resolved
| @@ -101,14 +108,16 @@ class ViewResolver(resolver: Resolver, catalogManager: CatalogManager) | |||
| val prevContext = if (viewResolutionContextStack.isEmpty()) { | |||
| ViewResolutionContext( | |||
| nestedViewDepth = 0, | |||
| maxNestedViewDepth = conf.maxNestedViewDepth | |||
| maxNestedViewDepth = conf.maxNestedViewDepth, | |||
| catalogAndNamespace = unresolvedView.desc.viewCatalogAndNamespace | |||
There was a problem hiding this comment.
This duplication will quickly get annoying, let's not do that.
…ual' into fixViewResolutionInDual
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix for Dual run of Single-Pass Analyzer with Bridging enabled.
Why are the changes needed?
SPARK-30284: CREATE VIEW should track the current catalog and namespacetest was failing when Bridging is enabled.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Fixing specific tests. Tests run locally.
Was this patch authored or co-authored using generative AI tooling?
No.