SOLR-17342 Avoid loading from remote CDN #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
approved these changes
Jan 22, 2025
Add comment in css for unused slider css
I did not either, so I changed it to EDIT: Pelican templates folder is indeed parsed by Jinja2, so |
|
Interestingly, the staging site already reports errors due to CSP. So after merge we'll be able to verify that these are now gone. |
Add license headers and LICENSE files
|
I added licensing headers for CSS and LICENSE.txt files for the fonts to be more explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/SOLR-17342 for background.
This PR stores some fonts and CSS locally in the static site instead of relying on CDN.
For the "Slick" carousel I cannot see that it is in use on our site now, so I have commented it out instead of downloading and adding to the repo. If you know that we'll need a carousel/slider we can re-enable it once we need it. Otherwise, the code can simply be removed.
I used the tool Google Font Downloader for downloading the two google fonts. FontAwesome was downloaded and added manually. It is not the latest version...
Tested the PR locally with
./build.sh -l