-
Notifications
You must be signed in to change notification settings - Fork 15
SLING-12739 - selectively hide scripts and servlets from the Sling resolver #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added integration tests, in branches for now, at: |
|
@@ -460,6 +469,16 @@ private Resource getErrorResource(final SlingHttpServletRequest request) { | |||
return res; | |||
} | |||
|
|||
/** @return true if the given Resource is hidden by our resourceHidingPredicate */ | |||
private boolean isHidden(Resource r) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would explicitly mention that this method requires a non-null parameter (and that for this reason null-checks are missing).
private boolean isHidden(Resource r) { | |
private boolean isHidden(@NotNull Resource r) { |
Work in progress, initial implementation with incomplete tests