Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 2429 #2432

Merged
merged 3 commits into from
Aug 25, 2024
Merged

fix Issue 2429 #2432

merged 3 commits into from
Aug 25, 2024

Conversation

wjdxw
Copy link
Contributor

@wjdxw wjdxw commented Aug 18, 2024

Fixes #2429.

Changes proposed in this pull request:

linghengqian
linghengqian reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The PR did not pass the code formatting validation. You can execute first ./mvnw spotless:apply -Pcheck -T1C. Then execute ./mvnw checkstyle:check -Pcheck -T1C to manually adjust to repair the CI.

@wjdxw
Copy link
Contributor Author

wjdxw commented Aug 25, 2024

Hello, the code has been updated. Only modified the code that caused the second issue mentioned earlier.

linghengqian
linghengqian approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linghengqian linghengqian merged commit ca353c3 into apache:master Aug 25, 2024
15 checks passed
@linghengqian linghengqian added this to the 3.1.0 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghengqian linghengqian linghengqian approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

失效转移导致job不在执行
2 participants
@wjdxw @linghengqian