Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9172] Clean pull offset and reset offset when delete subscription group #9173

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #9172

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.02%. Comparing base (c24f654) to head (4a7745b).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
.../rocketmq/broker/offset/ConsumerOffsetManager.java 94.11% 0 Missing and 1 partial ⚠️
...c/main/java/org/apache/rocketmq/common/MixAll.java 50.00% 1 Missing ⚠️
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9173      +/-   ##
=============================================
- Coverage      48.09%   48.02%   -0.07%     
+ Complexity     12103    12085      -18     
=============================================
  Files           1321     1321              
  Lines          93040    93033       -7     
  Branches       11924    11924              
=============================================
- Hits           44745    44683      -62     
- Misses         42782    42816      +34     
- Partials        5513     5534      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dingshuangxi888 dingshuangxi888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RongtongJin
RongtongJin previously approved these changes Feb 12, 2025
@RongtongJin RongtongJin merged commit 61ea512 into apache:develop Feb 12, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Clean pull offset and reset offset when delete subscription group
7 participants