RANGER-4400: Fixed ConcurrentModificationException in RangerKafkaAuditHandler.processResults(Collection<RangerAccessResult> results) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tHandler.processResults(Collection<RangerAccessResult> results)
rameeshm
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously added patch for RANGER-4400 used auditEventList in processResults() for the collection of requests and flushed them at a later stage in flushAudit(). This approach results in ConcurrentModificationException because auditEventList can get modified (more events added) while audit events getting flushed.
Instead of collecting these audit events in an array list, this patch flushes the audit event one at a time while they are being processed. This prevents the ConcurrentModificationException as no array list is used.
How was this patch tested?
system tests with kafka