-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance data schema generation for empty response #14918
Enhance data schema generation for empty response #14918
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14918 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1471 +1264
============================================
Files 2436 2708 +272
Lines 133233 151539 +18306
Branches 20636 23398 +2762
============================================
+ Hits 82274 96580 +14306
- Misses 44911 47704 +2793
- Partials 6048 7255 +1207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the enhancements Jackie, looks good to me.
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/utils/ParserUtils.java
Outdated
Show resolved
Hide resolved
* Response data schema can be inaccurate or incomplete in several forms: | ||
* 1. No result table at all (when all segments have been pruned on broker). | ||
* 2. Data schema has all columns set to default type (STRING) (when all segments pruned on server). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have contradictory feelings about explaining why some issues can happen in the generic method that solves them. On the one hand, it is useful to have the reasons centralized. On the other hand, it is a clear candidate for documentation that could be desynchronized with the code (ie we change one of these cases and forget to change the javadoc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need a dev focus documentation to document the internal behaviors. It is always a hard problem to keep the doc in sync with code though. I'd prefer having it in javadoc for now for future developers to know the history
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/utils/ParserUtils.java
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/utils/ParserUtils.java
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/utils/ParserUtils.java
Show resolved
Hide resolved
2c3dea9
to
5c7ac6c
Compare
This is a followup on #14836 with the following enhancements: