Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pinot-protobuf plugin to pinot-protobuf and pinot-confluent-protobuf #14858

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

xiangfu0
Copy link
Contributor

#14835

Split the confluent related code from pinot-protobuf to pinot-confluent-protobuf .

So the users have concern about confluent license could remove the pinot-confluent-protobuf shaded jar from the plugin directory.

@xiangfu0 xiangfu0 force-pushed the fixing-kafka-protobuf-license branch 3 times, most recently from 146d7a4 to f721e77 Compare January 21, 2025 22:01
@xiangfu0 xiangfu0 force-pushed the fixing-kafka-protobuf-license branch from f721e77 to d1b4433 Compare January 21, 2025 22:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (59551e4) to head (d1b4433).
Report is 1602 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14858      +/-   ##
============================================
+ Coverage     61.75%   63.76%   +2.01%     
- Complexity      207     1464    +1257     
============================================
  Files          2436     2707     +271     
  Lines        133233   151261   +18028     
  Branches      20636    23352    +2716     
============================================
+ Hits          82274    96449   +14175     
- Misses        44911    47565    +2654     
- Partials       6048     7247    +1199     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.73% <ø> (+2.02%) ⬆️
java-21 63.61% <ø> (+1.99%) ⬆️
skip-bytebuffers-false 63.75% <ø> (+2.00%) ⬆️
skip-bytebuffers-true 63.59% <ø> (+35.86%) ⬆️
temurin 63.76% <ø> (+2.01%) ⬆️
unittests 63.75% <ø> (+2.01%) ⬆️
unittests1 56.29% <ø> (+9.39%) ⬆️
unittests2 34.07% <ø> (+6.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 438e107 into apache:master Jan 22, 2025
23 checks passed
@xiangfu0 xiangfu0 deleted the fixing-kafka-protobuf-license branch January 22, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants