Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds push-based-ingestion plugin POC #14851

Closed
wants to merge 1 commit into from

Conversation

gviedma
Copy link
Contributor

@gviedma gviedma commented Jan 21, 2025

This PR adds a proof-of-concept for a push-based ingestion API by:

  • Creating an in-memory ring buffer to store ingested records
  • Creating a new consumer type that reads from in-memory buffer
  • Starting a new HTTP server endpoint embedded in the pinot-server to push records to in-memory buffer.

To push records to the new end-point, you can use curl like so:

curl --header 'Content-Type: application/octet-stream' --data @/Users/genunez/dev/oss/pinot/pinot-tools/src/main/resources/examples/stream/pushBasedIngestionDemo/rawdata/pushBasedIngestionDemo_data.json http://localhost:8989/ingestion/records/${tableName}

where tableName is that table you are pushing records to.

@gviedma gviedma closed this Jan 21, 2025
@gviedma gviedma deleted the push-based-ingestion-poc branch January 21, 2025 16:31
@gviedma gviedma restored the push-based-ingestion-poc branch January 21, 2025 16:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.75%. Comparing base (59551e4) to head (baf7f84).
Report is 1598 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14851      +/-   ##
============================================
+ Coverage     61.75%   63.75%   +2.00%     
- Complexity      207     1611    +1404     
============================================
  Files          2436     2708     +272     
  Lines        133233   151293   +18060     
  Branches      20636    23357    +2721     
============================================
+ Hits          82274    96455   +14181     
- Misses        44911    47590    +2679     
- Partials       6048     7248    +1200     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.73% <ø> (+2.02%) ⬆️
java-21 63.61% <ø> (+1.98%) ⬆️
skip-bytebuffers-false 63.74% <ø> (+2.00%) ⬆️
skip-bytebuffers-true 63.59% <ø> (+35.86%) ⬆️
temurin 63.75% <ø> (+2.00%) ⬆️
unittests 63.74% <ø> (+2.00%) ⬆️
unittests1 56.29% <ø> (+9.40%) ⬆️
unittests2 34.06% <ø> (+6.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants