Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTILE window function #14850

Merged
merged 1 commit into from
Jan 22, 2025
Merged

NTILE window function #14850

merged 1 commit into from
Jan 22, 2025

Conversation

yashmayya
Copy link
Collaborator

@yashmayya yashmayya added feature multi-stage Related to the multi-stage query engine window-functions Related to SQL window functions on the multi-stage query engine labels Jan 21, 2025
@yashmayya yashmayya marked this pull request as ready for review January 21, 2025 12:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.74%. Comparing base (59551e4) to head (a1d81ce).
Report is 1598 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14850      +/-   ##
============================================
+ Coverage     61.75%   63.74%   +1.99%     
- Complexity      207     1611    +1404     
============================================
  Files          2436     2709     +273     
  Lines        133233   151318   +18085     
  Branches      20636    23362    +2726     
============================================
+ Hits          82274    96463   +14189     
- Misses        44911    47610    +2699     
- Partials       6048     7245    +1197     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.70% <100.00%> (+1.99%) ⬆️
java-21 63.63% <100.00%> (+2.01%) ⬆️
skip-bytebuffers-false 63.71% <100.00%> (+1.97%) ⬆️
skip-bytebuffers-true 63.62% <100.00%> (+35.89%) ⬆️
temurin 63.74% <100.00%> (+1.99%) ⬆️
unittests 63.74% <100.00%> (+1.99%) ⬆️
unittests1 56.31% <100.00%> (+9.41%) ⬆️
unittests2 34.03% <4.00%> (+6.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock!

@yashmayya yashmayya merged commit 17f94a9 into apache:master Jan 22, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature multi-stage Related to the multi-stage query engine window-functions Related to SQL window functions on the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants