Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add option to show visualized query stats #14848

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

jayeshchoudhary
Copy link
Contributor

@jayeshchoudhary jayeshchoudhary commented Jan 21, 2025

This is feature, ui

Changelog

  • Add option to toggle between Tabular, Json and Visual view
  • Show query stats in graph format

TODO

  • calculate accurate width of nodes so that the edges are connected properly, right now they are slightly tilted.
  • club send and receive nodes into the middle node

  • Before
image
  • After
image image
  • Recording
query-stats.mp4
  • when no stats is available (eg V1 queries)
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (59551e4) to head (b12a4a6).
Report is 1597 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14848      +/-   ##
============================================
+ Coverage     61.75%   63.76%   +2.01%     
- Complexity      207     1610    +1403     
============================================
  Files          2436     2708     +272     
  Lines        133233   151225   +17992     
  Branches      20636    23345    +2709     
============================================
+ Hits          82274    96433   +14159     
- Misses        44911    47557    +2646     
- Partials       6048     7235    +1187     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.73% <ø> (+2.02%) ⬆️
java-21 63.64% <ø> (+2.02%) ⬆️
skip-bytebuffers-false 63.75% <ø> (+2.00%) ⬆️
skip-bytebuffers-true 63.62% <ø> (+35.89%) ⬆️
temurin 63.76% <ø> (+2.01%) ⬆️
unittests 63.76% <ø> (+2.01%) ⬆️
unittests1 56.33% <ø> (+9.44%) ⬆️
unittests2 34.05% <ø> (+6.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashmayya yashmayya added feature ui UI related issue multi-stage Related to the multi-stage query engine labels Jan 21, 2025
@gortiz gortiz merged commit 7356304 into apache:master Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature multi-stage Related to the multi-stage query engine ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants