Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Provide user access to all tables except tableX #14839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DaniilRoman
Copy link
Contributor

@DaniilRoman DaniilRoman commented Jan 18, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (59551e4) to head (33db5bc).
Report is 1594 commits behind head on master.

Files with missing lines Patch % Lines
...ntroller/helix/core/PinotHelixResourceManager.java 0.00% 3 Missing ⚠️
...ava/org/apache/pinot/core/auth/BasicAuthUtils.java 25.00% 3 Missing ⚠️
...mon/utils/config/AccessControlUserConfigUtils.java 60.00% 1 Missing and 1 partial ⚠️
...che/pinot/spi/utils/builder/UserConfigBuilder.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14839      +/-   ##
============================================
+ Coverage     61.75%   63.84%   +2.09%     
- Complexity      207     1611    +1404     
============================================
  Files          2436     2708     +272     
  Lines        133233   151240   +18007     
  Branches      20636    23346    +2710     
============================================
+ Hits          82274    96564   +14290     
- Misses        44911    47414    +2503     
- Partials       6048     7262    +1214     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.81% <52.38%> (+2.10%) ⬆️
java-21 63.67% <52.38%> (+2.04%) ⬆️
skip-bytebuffers-false 63.83% <52.38%> (+2.08%) ⬆️
skip-bytebuffers-true 63.62% <52.38%> (+35.89%) ⬆️
temurin 63.84% <52.38%> (+2.09%) ⬆️
unittests 63.84% <52.38%> (+2.09%) ⬆️
unittests1 56.34% <27.77%> (+9.45%) ⬆️
unittests2 34.13% <38.09%> (+6.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaniilRoman
Copy link
Contributor Author

Please, let me know if I need to update any changelog or documentation 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants