Improve reported dataTypes on V1 when no rows returned #14836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14836 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1610 +1403
============================================
Files 2436 2708 +272
Lines 133233 151277 +18044
Branches 20636 23357 +2721
============================================
+ Hits 82274 96412 +14138
- Misses 44911 47633 +2722
- Partials 6048 7232 +1184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
reviewed
Jan 21, 2025
...ion-tests/src/test/java/org/apache/pinot/integration/tests/EmptyResponseIntegrationTest.java
Show resolved
Hide resolved
gortiz
approved these changes
Jan 21, 2025
|
cc @Jackie-Jiang you were involved in this discussion, so you may be interested in looking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V1 just uses STRING as default data type for all columns when no data has been returned by servers.
This is an attempt to improve that by different strategies, being the preferred one use the schema validation implemented on V2 and reuse the data types determined by it. As a failback and only suitable for non-transformed fields, the base table schema is used. Otherwise, the default STRING type is still returned.