Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msqe-case-insensitive-enabled #14830

Merged
merged 18 commits into from
Jan 23, 2025

Conversation

albertobastos
Copy link
Contributor

closes #14675

Backwards compatibility:

When enable.case.insensitive=true (the default value) responses using MSQE will return the contents of tablesQueried always in lowercase. That's due to how internally Calcite is used for column validation and how it handles a case-insensitive scenario. Given that it happens when a cluster is configured as case-insensitive, hopefully the consumer will also be prepared to ignore case when using that response field.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (59551e4) to head (115908e).
Report is 1617 commits behind head on master.

Files with missing lines Patch % Lines
...t/controller/api/resources/PinotQueryResource.java 0.00% 9 Missing ⚠️
...a/org/apache/pinot/query/catalog/PinotCatalog.java 0.00% 7 Missing ⚠️
...a/org/apache/pinot/common/utils/DatabaseUtils.java 20.00% 1 Missing and 3 partials ⚠️
.../java/org/apache/pinot/query/QueryEnvironment.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14830      +/-   ##
============================================
+ Coverage     61.75%   63.78%   +2.03%     
- Complexity      207     1472    +1265     
============================================
  Files          2436     2708     +272     
  Lines        133233   151423   +18190     
  Branches      20636    23376    +2740     
============================================
+ Hits          82274    96585   +14311     
- Misses        44911    47591    +2680     
- Partials       6048     7247    +1199     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.72% <40.00%> (+2.01%) ⬆️
java-21 63.68% <40.00%> (+2.05%) ⬆️
skip-bytebuffers-false 63.77% <40.00%> (+2.03%) ⬆️
skip-bytebuffers-true 63.62% <40.00%> (+35.89%) ⬆️
temurin 63.78% <40.00%> (+2.03%) ⬆️
unittests 63.78% <40.00%> (+2.03%) ⬆️
unittests1 56.32% <42.30%> (+9.43%) ⬆️
unittests2 34.06% <22.85%> (+6.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added backward-incompat Referenced by PRs that introduce or fix backward compat issues bugfix multi-stage Related to the multi-stage query engine labels Jan 17, 2025
Copy link
Collaborator

@yashmayya yashmayya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @albertobastos! I've left a few minor comments and questions.

Copy link
Contributor Author

@albertobastos albertobastos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next comments batch ready @yashmayya , thanks for looking into it!

Copy link
Collaborator

@yashmayya yashmayya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @albertobastos!

@yashmayya yashmayya merged commit a88d6b9 into apache:master Jan 23, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-incompat Referenced by PRs that introduce or fix backward compat issues bugfix multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-stage query engine doesn't respect the enable.case.insensitive cluster config
4 participants