[flaky-test] BrokerManagedAsyncExecutorProviderTest#testRejectHandler #14814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ker/src/test/java/org/apache/pinot/broker/broker/BrokerManagedAsyncExecutorProviderTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14814 +/- ##
============================================
+ Coverage 61.75% 63.77% +2.02%
- Complexity 207 1611 +1404
============================================
Files 2436 2707 +271
Lines 133233 151209 +17976
Branches 20636 23344 +2708
============================================
+ Hits 82274 96429 +14155
- Misses 44911 47542 +2631
- Partials 6048 7238 +1190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tibrewalpratik17
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14651
It might be possible that the test executes all 10 tasks sequentially one after another. In this case, the test fails.
The change:
phaser::arriveAndAwaitAdvancetriggers a waisting for thephaser.arriveAndDeregister();call.But by doing this I explicitly overflow the thread pool.