From 5de314e876b2972502a9b32d22f3ba263b2ab5b6 Mon Sep 17 00:00:00 2001 From: cutiepie-10 Date: Mon, 13 Jan 2025 22:29:46 +0530 Subject: [PATCH 1/4] Adding error message in the SchemUtils.java --- .../java/org/apache/pinot/segment/local/utils/SchemaUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java index 9661923d30d9..497bbee6bd72 100644 --- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java +++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java @@ -176,7 +176,7 @@ private static void validateCompatibilityWithTableConfig(Schema schema, TableCon } catch (Exception e) { throw new IllegalStateException( "Schema is incompatible with tableConfig with name: " + tableConfig.getTableName() + " and type: " - + tableConfig.getTableType(), e); + + tableConfig.getTableType()+" Caused By: "+e.getMessage(), e); } } From 435e4622b65bd01eb2a155fe043c084cf7899d66 Mon Sep 17 00:00:00 2001 From: cutiepie-10 Date: Tue, 14 Jan 2025 15:54:08 +0530 Subject: [PATCH 2/4] Corrected the error message --- .../java/org/apache/pinot/segment/local/utils/SchemaUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java index 497bbee6bd72..07274029b1e4 100644 --- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java +++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java @@ -176,7 +176,7 @@ private static void validateCompatibilityWithTableConfig(Schema schema, TableCon } catch (Exception e) { throw new IllegalStateException( "Schema is incompatible with tableConfig with name: " + tableConfig.getTableName() + " and type: " - + tableConfig.getTableType()+" Caused By: "+e.getMessage(), e); + + tableConfig.getTableType()+", reason: "+e.getMessage(), e); } } From f3b323170a58f9511b03c47fb1eb6b757e034624 Mon Sep 17 00:00:00 2001 From: cutiepie-10 Date: Fri, 17 Jan 2025 00:50:12 +0530 Subject: [PATCH 3/4] Validated for checkstyle --- .../java/org/apache/pinot/segment/local/utils/SchemaUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java index 07274029b1e4..a8017ba17dad 100644 --- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java +++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java @@ -176,7 +176,7 @@ private static void validateCompatibilityWithTableConfig(Schema schema, TableCon } catch (Exception e) { throw new IllegalStateException( "Schema is incompatible with tableConfig with name: " + tableConfig.getTableName() + " and type: " - + tableConfig.getTableType()+", reason: "+e.getMessage(), e); + + tableConfig.getTableType() + ", reason: " + e.getMessage(), e); } } From bfe33403f7448fed7b40f2f5f2885d6121423654 Mon Sep 17 00:00:00 2001 From: "Xiaotian (Jackie) Jiang" <17555551+Jackie-Jiang@users.noreply.github.com> Date: Thu, 16 Jan 2025 20:43:30 -0800 Subject: [PATCH 4/4] Minor formatting change --- .../java/org/apache/pinot/segment/local/utils/SchemaUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java index a8017ba17dad..63eef83214af 100644 --- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java +++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java @@ -176,7 +176,7 @@ private static void validateCompatibilityWithTableConfig(Schema schema, TableCon } catch (Exception e) { throw new IllegalStateException( "Schema is incompatible with tableConfig with name: " + tableConfig.getTableName() + " and type: " - + tableConfig.getTableType() + ", reason: " + e.getMessage(), e); + + tableConfig.getTableType() + ", reason: " + e.getMessage(), e); } }