Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default use of outputSegmentMaxSize in UpsertCompactMerge task #14766

Conversation

tibrewalpratik17
Copy link
Contributor

Small followup from the comment: #14742 (comment)

Copy link
Contributor

@swaminathanmanish swaminathanmanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be you can add log.info to indicate what all has been configured by the user, so that it helps during debugging.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (59551e4) to head (10226ac).
Report is 1546 commits behind head on master.

Files with missing lines Patch % Lines
...tcompactmerge/UpsertCompactMergeTaskGenerator.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14766      +/-   ##
============================================
+ Coverage     61.75%   63.85%   +2.10%     
- Complexity      207     1606    +1399     
============================================
  Files          2436     2703     +267     
  Lines        133233   150806   +17573     
  Branches      20636    23298    +2662     
============================================
+ Hits          82274    96300   +14026     
- Misses        44911    47303    +2392     
- Partials       6048     7203    +1155     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.81% <0.00%> (+2.10%) ⬆️
java-21 63.74% <0.00%> (+2.12%) ⬆️
skip-bytebuffers-false 63.84% <0.00%> (+2.09%) ⬆️
skip-bytebuffers-true 63.71% <0.00%> (+35.98%) ⬆️
temurin 63.85% <0.00%> (+2.10%) ⬆️
unittests 63.85% <0.00%> (+2.10%) ⬆️
unittests1 56.28% <ø> (+9.38%) ⬆️
unittests2 34.16% <0.00%> (+6.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tibrewalpratik17 tibrewalpratik17 force-pushed the remove_default_upsert_compact branch from 3a2a583 to 10226ac Compare January 7, 2025 11:57
@tibrewalpratik17 tibrewalpratik17 marked this pull request as ready for review January 7, 2025 11:59
@tibrewalpratik17 tibrewalpratik17 merged commit 82bf63c into apache:master Jan 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants