[perf] Run Inverted Index Before Other Operators #14764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14764 +/- ##
============================================
+ Coverage 61.75% 63.84% +2.09%
- Complexity 207 1607 +1400
============================================
Files 2436 2703 +267
Lines 133233 150738 +17505
Branches 20636 23289 +2653
============================================
+ Hits 82274 96236 +13962
- Misses 44911 47298 +2387
- Partials 6048 7204 +1156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14744
This is still not the "ideal approach". Currently we always reorder AND predicates based on these priorities, but sometimes users may have selective filters which are lower priority.
We could do more sophisticated optimizations in the future, like dynamically re-arranging predicates, which could be helpful for scenarios where we have 1000s of segments to be filtered in a single server.
But I'll defer that to later.